Re: [PATCH net-next 2/5 v2] net: gemini: Improve connection prints

2018-07-08 Thread Linus Walleij
On Wed, Jul 4, 2018 at 10:40 PM Andrew Lunn wrote: > On Wed, Jul 04, 2018 at 08:33:21PM +0200, Linus Walleij wrote: > > @@ -300,23 +305,26 @@ static void gmac_speed_set(struct net_device *netdev) > > status.bits.speed = GMAC_SPEED_1000; > > if (phydev->interface ==

Re: [PATCH net-next 2/5 v2] net: gemini: Improve connection prints

2018-07-04 Thread Andrew Lunn
On Wed, Jul 04, 2018 at 08:33:21PM +0200, Linus Walleij wrote: > Switch over to using a module parameter and debug prints > that can be controlled by this or ethtool like everyone > else. Depromote all other prints to debug messages. > > Signed-off-by: Linus Walleij > --- > ChangeLog v1->v2: > -

[PATCH net-next 2/5 v2] net: gemini: Improve connection prints

2018-07-04 Thread Linus Walleij
Switch over to using a module parameter and debug prints that can be controlled by this or ethtool like everyone else. Depromote all other prints to debug messages. Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Use a module parameter and the message levels like all other drivers and