Re: [PATCH net-next 2/6] atl1c: remove private tx lock

Florian Westphal : > Francois Romieu wrote: [...] > > Play it safe and keep the implicit local_irq_{save / restore} call ? > > > > It may not be needed but it will help avoiding any unexpected regression > > report pointing at the NETDEV_TX_LOCKED removal

Re: [PATCH net-next 2/6] atl1c: remove private tx lock

Florian Westphal : [...] > diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c > b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c > index d0084d4..a3200ea 100644 > --- a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c > +++

Re: [PATCH net-next 2/6] atl1c: remove private tx lock

Francois Romieu wrote: > Florian Westphal : > [...] > > diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c > > b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c > > index d0084d4..a3200ea 100644 > > ---

Re: [PATCH net-next 2/6] atl1c: remove private tx lock

Florian Westphal : [...] > diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c > b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c > index d0084d4..a3200ea 100644 > --- a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c > +++

[PATCH net-next 2/6] atl1c: remove private tx lock

AFAICS this is safe: the lock is only used in the .ndo_start_xmit function and this driver does not set LLTX. Gets rid of TX_LOCKED return value, followup patches will remove it. Cc: Jay Cliburn Cc: Chris Snook Signed-off-by: Florian Westphal