Re: [PATCH net-next 4/6] net: use core MTU range checking in core net infra

2016-10-19 Thread Sabrina Dubroca
2016-10-18, 22:33:31 -0400, Jarod Wilson wrote: > geneve: > - Merge __geneve_change_mtu back into geneve_change_mtu, set max_mtu > - This one isn't quite as straight-forward as others, could use some > closer inspection and testing > > macvlan: > - set min/max_mtu > > tun: > - set min/max_mtu,

Re: [PATCH net-next 4/6] net: use core MTU range checking in core net infra

2016-10-19 Thread Jarod Wilson
On Wed, Oct 19, 2016 at 05:28:00PM +0200, Sabrina Dubroca wrote: > 2016-10-19, 10:40:06 -0400, Jarod Wilson wrote: > > On Wed, Oct 19, 2016 at 03:55:29PM +0200, Sabrina Dubroca wrote: > > > 2016-10-18, 22:33:31 -0400, Jarod Wilson wrote: ... > > I'm thinking more and more that we ought to back out

Re: [PATCH net-next 4/6] net: use core MTU range checking in core net infra

2016-10-19 Thread Sabrina Dubroca
2016-10-19, 10:40:06 -0400, Jarod Wilson wrote: > On Wed, Oct 19, 2016 at 03:55:29PM +0200, Sabrina Dubroca wrote: > > 2016-10-18, 22:33:31 -0400, Jarod Wilson wrote: > > > geneve: > > > - Merge __geneve_change_mtu back into geneve_change_mtu, set max_mtu > > > - This one isn't quite as straight-fo

Re: [PATCH net-next 4/6] net: use core MTU range checking in core net infra

2016-10-19 Thread Jarod Wilson
On Wed, Oct 19, 2016 at 02:17:03PM +0200, Jiri Benc wrote: > On Tue, 18 Oct 2016 22:33:31 -0400, Jarod Wilson wrote: > > --- a/drivers/net/vxlan.c > > +++ b/drivers/net/vxlan.c > > @@ -2367,43 +2367,31 @@ static void vxlan_set_multicast_list(struct > > net_device *dev) > > { > > } > > > > -sta

Re: [PATCH net-next 4/6] net: use core MTU range checking in core net infra

2016-10-19 Thread Jiri Benc
On Tue, 18 Oct 2016 22:33:31 -0400, Jarod Wilson wrote: > --- a/drivers/net/vxlan.c > +++ b/drivers/net/vxlan.c > @@ -2367,43 +2367,31 @@ static void vxlan_set_multicast_list(struct > net_device *dev) > { > } > > -static int __vxlan_change_mtu(struct net_device *dev, > -

Re: [PATCH net-next 4/6] net: use core MTU range checking in core net infra

2016-10-19 Thread Jarod Wilson
On Wed, Oct 19, 2016 at 03:55:29PM +0200, Sabrina Dubroca wrote: > 2016-10-18, 22:33:31 -0400, Jarod Wilson wrote: > > geneve: > > - Merge __geneve_change_mtu back into geneve_change_mtu, set max_mtu > > - This one isn't quite as straight-forward as others, could use some > > closer inspection an

[PATCH net-next 4/6] net: use core MTU range checking in core net infra

2016-10-18 Thread Jarod Wilson
geneve: - Merge __geneve_change_mtu back into geneve_change_mtu, set max_mtu - This one isn't quite as straight-forward as others, could use some closer inspection and testing macvlan: - set min/max_mtu tun: - set min/max_mtu, remove tun_net_change_mtu vxlan: - Merge __vxlan_change_mtu back in