Re: [PATCH net-next 4/6] tcp: remove header prediction

2017-08-01 Thread Neal Cardwell
On Sat, Jul 29, 2017 at 9:57 PM, Florian Westphal wrote: > @@ -5519,11 +5347,10 @@ void tcp_finish_connect(struct sock *sk, struct > sk_buff *skb) > if (sock_flag(sk, SOCK_KEEPOPEN)) > inet_csk_reset_keepalive_timer(sk, keepalive_time_when(tp)); > > - if (!tp->rx_opt

[PATCH net-next 4/6] tcp: remove header prediction

2017-07-29 Thread Florian Westphal
Like prequeue, I am not sure this is overly useful nowadays. If we receive a train of packets, GRO will aggregate them if the headers are the same (HP predates GRO by several years) so we don't get a per-packet benefit, only a per-aggregated-packet one. Signed-off-by: Florian Westphal --- inclu

[RFC PATCH net-next 4/6] tcp: remove header prediction

2017-07-27 Thread Florian Westphal
Like prequeue, I am not sure this is overly useful nowadays. If we receive a train of packets, GRO will aggregate them if the headers are the same (HP predates GRO by several years) so we don't get a per-packet benefit, only a per-aggregated-packet one. Signed-off-by: Florian Westphal --- inclu