Re: [PATCH net-next 5/5] tls: Add generic NIC offload infrastructure.

2017-09-20 Thread Hannes Frederic Sowa
Hello, Boris Pismenny writes: > Hello, > > Hannes Frederic Sowa writes: >> Hello, >> >> Ilya Lesokhin writes: >> >> > Hannes Frederic Sowa writes: >> > >> >> The user should be aware of that

RE: [PATCH net-next 5/5] tls: Add generic NIC offload infrastructure.

2017-09-19 Thread Boris Pismenny
Hello, Hannes Frederic Sowa writes: > Hello, > > Ilya Lesokhin writes: > > > Hannes Frederic Sowa writes: > > > >> The user should be aware of that they can't migrate the socket to > >> another interface if they got

Re: [PATCH net-next 5/5] tls: Add generic NIC offload infrastructure.

2017-09-19 Thread Hannes Frederic Sowa
Hello, Ilya Lesokhin writes: > Hannes Frederic Sowa writes: > >> The user should be aware of that they can't migrate the socket to another >> interface if they got hw offloaded. This is not the case for software >> offload. >> Thus I think the

RE: [PATCH net-next 5/5] tls: Add generic NIC offload infrastructure.

2017-09-19 Thread Ilya Lesokhin
Hannes Frederic Sowa writes: > The user should be aware of that they can't migrate the socket to another > interface if they got hw offloaded. This is not the case for software offload. > Thus I think the user has to opt in and it shouldn't be a heuristic until we >

Re: [PATCH net-next 5/5] tls: Add generic NIC offload infrastructure.

2017-09-18 Thread Hannes Frederic Sowa
Ilya Lesokhin writes: > +/* We assume that the socket is already connected */ > +static struct net_device *get_netdev_for_sock(struct sock *sk) > +{ > + struct inet_sock *inet = inet_sk(sk); > + struct net_device *netdev = NULL; > + > + netdev =

[PATCH net-next 5/5] tls: Add generic NIC offload infrastructure.

2017-09-14 Thread Ilya Lesokhin
This patch adds a generic infrastructure to offload TLS crypto to a network devices. It enables the kernel TLS socket to skip encryption and authentication operations on the transmit side of the data path. Leaving those computationally expensive operations to the NIC. The NIC offload