Re: [PATCH net-next 5/5] udp: add recvmmsg implementation

2016-11-29 Thread Hannes Frederic Sowa
Hello, On Wed, Nov 30, 2016, at 01:22, David Miller wrote: > From: Hannes Frederic Sowa > Date: Fri, 25 Nov 2016 18:09:00 +0100 > > > During review we discussed on how to handle major errors in the kernel: > > > > The old code and the new code still can report back success even though > > the k

Re: [PATCH net-next 5/5] udp: add recvmmsg implementation

2016-11-29 Thread David Miller
From: Hannes Frederic Sowa Date: Fri, 25 Nov 2016 18:09:00 +0100 > During review we discussed on how to handle major errors in the kernel: > > The old code and the new code still can report back success even though > the kernel got back an EFAULT while copying from kernel space to user > space (

RE: [PATCH net-next 5/5] udp: add recvmmsg implementation

2016-11-28 Thread David Laight
From: Hannes Frederic Sowa > Sent: 25 November 2016 17:09 ... > Currently sk_err is set so the next syscall would get an -EFAULT, which > seems very bad and can also be overwritten by incoming icmp packets, so > we never get a notification that we actually had a bad pointer somewhere > in the mmsgh

Re: [PATCH net-next 5/5] udp: add recvmmsg implementation

2016-11-25 Thread Hannes Frederic Sowa
On 25.11.2016 16:39, Paolo Abeni wrote: > skbs are extracted from the receive queue in burts, and a single > sk_rmem_alloc/forward allocated memory update is performed for > each burst. > MSG_PEEK and MSG_ERRQUEUE are not supported to keep the implementation > as simple as possible. > > Signed-off

[PATCH net-next 5/5] udp: add recvmmsg implementation

2016-11-25 Thread Paolo Abeni
skbs are extracted from the receive queue in burts, and a single sk_rmem_alloc/forward allocated memory update is performed for each burst. MSG_PEEK and MSG_ERRQUEUE are not supported to keep the implementation as simple as possible. Signed-off-by: Sabrina Dubroca Signed-off-by: Paolo Abeni ---