Re: [PATCH net-next 5/5] vxlan: consolidate vxlan_xmit_skb and vxlan6_xmit_skb

2016-02-02 Thread Jiri Benc
On Tue, 02 Feb 2016 15:57:23 +0100, Paolo Abeni wrote: > I think there is an issue here: in vxlan_build_skb(), 'flags' will be > always tested against VXLAN_F_UDP_CSUM, but when tunneling over ipv6 we > should check VXLAN_F_UDP_ZERO_CSUM6_TX instead. You're correct. This IPv4/v6 flags schism is a

Re: [PATCH net-next 5/5] vxlan: consolidate vxlan_xmit_skb and vxlan6_xmit_skb

2016-02-02 Thread Paolo Abeni
On Tue, 2016-02-02 at 11:13 +0100, Jiri Benc wrote: > There's a lot of code duplication. Factor out the duplicate code to a new > function shared between IPv4 and IPv6 xmit path. > > Signed-off-by: Jiri Benc > --- > drivers/net/vxlan.c | 141 > +++

[PATCH net-next 5/5] vxlan: consolidate vxlan_xmit_skb and vxlan6_xmit_skb

2016-02-02 Thread Jiri Benc
There's a lot of code duplication. Factor out the duplicate code to a new function shared between IPv4 and IPv6 xmit path. Signed-off-by: Jiri Benc --- drivers/net/vxlan.c | 141 +++- 1 file changed, 29 insertions(+), 112 deletions(-) diff --git a