Re: [PATCH net-next 5/5] vxlan: implement GPE in L3 mode

2016-03-08 Thread Jesse Gross
On Sat, Feb 27, 2016 at 11:44 AM, Jiri Benc wrote: > On Sat, 27 Feb 2016 20:21:59 +0100, Jiri Benc wrote: >> You mean returning ETH_P_TEB in skb->protocol? That's not much useful, >> unfortunately. You won't get such packet processed by the kernel IP >> stack, rendering the VXLAN-GPE device unusab

Re: [PATCH net-next 5/5] vxlan: implement GPE in L3 mode

2016-02-27 Thread Jiri Benc
On Sat, 27 Feb 2016 20:21:59 +0100, Jiri Benc wrote: > You mean returning ETH_P_TEB in skb->protocol? That's not much useful, > unfortunately. You won't get such packet processed by the kernel IP > stack, rendering the VXLAN-GPE device unusable outside of ovs. It would > effectively became a packet

Re: [PATCH net-next 5/5] vxlan: implement GPE in L3 mode

2016-02-27 Thread Jiri Benc
On Fri, 26 Feb 2016 15:42:29 -0800, Tom Herbert wrote: > Agreed, and I don't see why there even needs to be modes. VXLAN-GPE > can carry arbitrary protocols with a next-header field. For Ethernet, > MPLS, IPv4, and IPv6 it should just be a simple mapping of the next > header to Ethertype for purpos

Re: [PATCH net-next 5/5] vxlan: implement GPE in L3 mode

2016-02-27 Thread Jiri Benc
On Fri, 26 Feb 2016 14:22:03 -0800, Jesse Gross wrote: > Given that VXLAN_GPE_MODE_L3 will eventually come to be used by NSH, > MPLS, etc. in addition to IPv4/v6, most of which are not really L3, it > seems like something along the lines of NO_ARP might be better since > that's what it really indic

Re: [PATCH net-next 5/5] vxlan: implement GPE in L3 mode

2016-02-26 Thread Tom Herbert
On Fri, Feb 26, 2016 at 2:22 PM, Jesse Gross wrote: > On Thu, Feb 25, 2016 at 11:48 PM, Jiri Benc wrote: >> diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h >> index c2b2b7462731..ee4f7198aa21 100644 >> --- a/include/uapi/linux/if_link.h >> +++ b/include/uapi/linux/if_link

Re: [PATCH net-next 5/5] vxlan: implement GPE in L3 mode

2016-02-26 Thread Jesse Gross
On Thu, Feb 25, 2016 at 11:48 PM, Jiri Benc wrote: > diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h > index c2b2b7462731..ee4f7198aa21 100644 > --- a/include/uapi/linux/if_link.h > +++ b/include/uapi/linux/if_link.h > @@ -464,6 +464,7 @@ enum { > enum vxlan_gpe_mode { >

[PATCH net-next 5/5] vxlan: implement GPE in L3 mode

2016-02-25 Thread Jiri Benc
Implement L3 mode for VXLAN-GPE (i.e. IPv4/IPv6 payload directly after the VXLAN header). The GPE header parsing has to be moved before iptunnel_pull_header, as we need to know the protocol. Signed-off-by: Jiri Benc --- drivers/net/vxlan.c | 127 +++-