Re: [PATCH net-next 6/6] e1000e: call ndo_stop() instead of dev_close() when running offline selftest

2016-02-03 Thread Stefan Assmann
On 02.02.2016 22:28, David Miller wrote: > > Always, when sending an updated version of a patch which is part of a > series, always resubmit the entire series rather than just the patch > which is changing. > > Thanks. > Sorry Dave, going to send out a complete V2 right away. Stefan

Re: [PATCH net-next 6/6] e1000e: call ndo_stop() instead of dev_close() when running offline selftest

2016-02-02 Thread David Miller
Always, when sending an updated version of a patch which is part of a series, always resubmit the entire series rather than just the patch which is changing. Thanks.

Re: [PATCH net-next 6/6] e1000e: call ndo_stop() instead of dev_close() when running offline selftest

2016-02-02 Thread Stefan Assmann
Here's a V2 that fixes the name collision. >From 8f617672b97324058adf5b8981c4b91defad8c3a Mon Sep 17 00:00:00 2001 From: Stefan Assmann Date: Mon, 1 Feb 2016 13:18:24 +0100 Subject: [PATCH net-next] e1000e: call ndo_stop() instead of dev_close() when running offline selftest Calling dev_close()

Re: [PATCH net-next 6/6] e1000e: call ndo_stop() instead of dev_close() when running offline selftest

2016-02-02 Thread kbuild test robot
Hi Stefan, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Stefan-Assmann/net-intel-call-ndo_stop-instead-of-dev_close-when-running-offline-selftest/20160202-182015 config: i386-defconfig (attached as .config) reproduce: # save the attached .co

[PATCH net-next 6/6] e1000e: call ndo_stop() instead of dev_close() when running offline selftest

2016-02-02 Thread Stefan Assmann
Calling dev_close() causes IFF_UP to be cleared which will remove the interfaces routes and some addresses. That's probably not what the user intended when running the offline selftest. Besides this does not happen if the interface is brought down before the test, so the current behaviour is incons