Re: [PATCH net-next 6/9] net/mlx4_en: Adding support of turning off link autonegotiation via ethtool

2017-01-16 Thread Or Gerlitz
On Tue, Jan 17, 2017 at 1:08 AM, Ariel Levkovich wrote: > + MLX4_PTYS_AN_DISABLE_CAP = 1 << 5, > > It's there. I'll look, but please bring a cake to the office, we started doing that in order to prevent people from replying in top posting to linux mailing list. Or.

Re: [PATCH net-next 6/9] net/mlx4_en: Adding support of turning off link autonegotiation via ethtool

2017-01-16 Thread Or Gerlitz
On Tue, Jan 17, 2017 at 1:08 AM, Ariel Levkovich wrote: > + MLX4_PTYS_AN_DISABLE_CAP = 1 << 5, > > It's there. It would be good to spare few words on that aspect in the change log.

RE: [PATCH net-next 6/9] net/mlx4_en: Adding support of turning off link autonegotiation via ethtool

2017-01-16 Thread Ariel Levkovich
and Twitter > -Original Message- > From: Or Gerlitz [mailto:gerlitz...@gmail.com] > Sent: Monday, January 16, 2017 4:48 PM > To: Tariq Toukan ; Ariel Levkovich > > Cc: David S. Miller ; Linux Netdev List > ; Eran Ben Elisha > Subject: Re: [PATCH net-next 6/9] net/mlx4_en: A

Re: [PATCH net-next 6/9] net/mlx4_en: Adding support of turning off link autonegotiation via ethtool

2017-01-16 Thread Or Gerlitz
On Mon, Jan 16, 2017 at 7:30 PM, Tariq Toukan wrote: 0644 > --- a/include/linux/mlx4/device.h > +++ b/include/linux/mlx4/device.h > @@ -1539,8 +1539,13 @@ enum mlx4_ptys_proto { > MLX4_PTYS_EN = 1<<2, > }; > > +enum mlx4_ptys_flags { > + MLX4_PTYS_AN_DISABLE_CAP = 1 << 5, > +

[PATCH net-next 6/9] net/mlx4_en: Adding support of turning off link autonegotiation via ethtool

2017-01-16 Thread Tariq Toukan
From: Ariel Levkovich This feature will allow the user to disable auto negotiation on the port for mlx4 devices while setting the speed is limited to 1GbE speeds. Other speeds will not be accepted in autoneg off mode. Signed-off-by: Ariel Levkovich Signed-off-by: Tariq Toukan --- drivers/net/