Re: [PATCH net-next 7/8] net: sched: act: handle extack in tcf_generic_walker

2018-02-13 Thread Alexander Aring
Hi, 2018-02-13 11:18 GMT-05:00 David Miller : > From: Davide Caratti > Date: Tue, 13 Feb 2018 10:58:01 +0100 > >> On Mon, 2018-02-12 at 15:19 -0500, Alexander Aring wrote: >>> >>> @@ -211,7 +212,8 @@ int tcf_generic_walker(struct tc_action_net *tn, struct >>> sk_buff *skb, >>> } else if (ty

Re: [PATCH net-next 7/8] net: sched: act: handle extack in tcf_generic_walker

2018-02-13 Thread David Miller
From: Davide Caratti Date: Tue, 13 Feb 2018 10:58:01 +0100 > On Mon, 2018-02-12 at 15:19 -0500, Alexander Aring wrote: >> >> @@ -211,7 +212,8 @@ int tcf_generic_walker(struct tc_action_net *tn, struct >> sk_buff *skb, >> } else if (type == RTM_GETACTION) { >> return tcf_dump_

Re: [PATCH net-next 7/8] net: sched: act: handle extack in tcf_generic_walker

2018-02-13 Thread Davide Caratti
On Mon, 2018-02-12 at 15:19 -0500, Alexander Aring wrote: > > @@ -211,7 +212,8 @@ int tcf_generic_walker(struct tc_action_net *tn, struct > sk_buff *skb, > } else if (type == RTM_GETACTION) { > return tcf_dump_walker(idrinfo, skb, cb); > } else { > - WARN(1,

[PATCH net-next 7/8] net: sched: act: handle extack in tcf_generic_walker

2018-02-12 Thread Alexander Aring
This patch adds extack handling for a common used TC act function "tcf_generic_walker()" to add an extack message on failures. The tcf_generic_walker() function can fail if get a invalid command different than DEL and GET. The naming "action" here is wrong, the correct naming would be command. Cc: