Re: [PATCH net-next 8/8] net: sched: cls_u32: add extack support

2018-01-16 Thread Cong Wang
On Tue, Jan 16, 2018 at 9:20 AM, Alexander Aring wrote: > - if (root_ht == ht) > + if (root_ht == ht) { > + NL_SET_ERR_MSG(extack, "Not allowd to delete root node"); s/allowd/allowed/

Re: [PATCH net-next 8/8] net: sched: cls_u32: add extack support

2018-01-16 Thread Jakub Kicinski
On Tue, 16 Jan 2018 12:20:27 -0500, Alexander Aring wrote: > @@ -780,14 +787,18 @@ static int u32_set_parms(struct net *net, struct > tcf_proto *tp, > u32 handle = nla_get_u32(tb[TCA_U32_LINK]); > struct tc_u_hnode *ht_down = NULL, *ht_old; > > - if (TC_U3

[PATCH net-next 8/8] net: sched: cls_u32: add extack support

2018-01-16 Thread Alexander Aring
This patch adds extack support for the u32 classifier as example for delete and init callback. Cc: David Ahern Signed-off-by: Alexander Aring --- net/sched/cls_u32.c | 66 - 1 file changed, 50 insertions(+), 16 deletions(-) diff --git a/net/s