Re: [PATCH net-next RFC] rtnetlink: add new RTM_GETSTATS to dump link stats

2016-02-25 Thread roopa
On 2/25/16, 8:26 AM, David Miller wrote: > From: roopa > Date: Wed, 24 Feb 2016 21:25:50 -0800 > >> I did go back and forth on the attribute vs mask. >> cosmetic but, i guess i did not feel good about having to redefine every >> attribute again >> for the bitmap filter

Re: [PATCH net-next RFC] rtnetlink: add new RTM_GETSTATS to dump link stats

2016-02-25 Thread David Miller
From: roopa Date: Wed, 24 Feb 2016 21:25:50 -0800 > I did go back and forth on the attribute vs mask. > cosmetic but, i guess i did not feel good about having to redefine every > attribute again > for the bitmap filter ...and i anticipate the list of stat attributes

Re: [PATCH net-next RFC] rtnetlink: add new RTM_GETSTATS to dump link stats

2016-02-24 Thread roopa
On 2/24/16, 1:40 PM, David Miller wrote: > From: Roopa Prabhu > Date: Mon, 22 Feb 2016 22:01:33 -0800 > >> From: Roopa Prabhu >> >> This patch adds a new RTM_GETSTATS message to query link stats via netlink >> from the kernel. RTM_NEWLINK

Re: [PATCH net-next RFC] rtnetlink: add new RTM_GETSTATS to dump link stats

2016-02-24 Thread roopa
On 2/23/16, 1:26 AM, Rosen, Rami wrote: > Hi, > > + if (!dev) > + return -ENODEV; > + > + nskb = nlmsg_new(if_nlmsg_stats_size(dev), GFP_KERNEL); > + if (!nskb) > + return -ENOBUFS; > + > + err = rtnl_fill_statsinfo(nskb, dev, RTM_NEWSTATS, > +

Re: [PATCH net-next RFC] rtnetlink: add new RTM_GETSTATS to dump link stats

2016-02-24 Thread David Miller
From: Roopa Prabhu Date: Mon, 22 Feb 2016 22:01:33 -0800 > From: Roopa Prabhu > > This patch adds a new RTM_GETSTATS message to query link stats via netlink > from the kernel. RTM_NEWLINK also dumps stats today, but RTM_NEWLINK returns a >

RE: [PATCH net-next RFC] rtnetlink: add new RTM_GETSTATS to dump link stats

2016-02-23 Thread Rosen, Rami
Hi, + if (!dev) + return -ENODEV; + + nskb = nlmsg_new(if_nlmsg_stats_size(dev), GFP_KERNEL); + if (!nskb) + return -ENOBUFS; + + err = rtnl_fill_statsinfo(nskb, dev, RTM_NEWSTATS, + NETLINK_CB(skb).portid,

[PATCH net-next RFC] rtnetlink: add new RTM_GETSTATS to dump link stats

2016-02-22 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds a new RTM_GETSTATS message to query link stats via netlink from the kernel. RTM_NEWLINK also dumps stats today, but RTM_NEWLINK returns a lot more than just stats and is expensive in some cases when frequent polling for stats from