Re: [PATCH net-next V2 03/16] net: fec: pass txq to fec_enet_tx_queue instead of queue_id

2016-03-04 Thread Troy Kisky
gt;>> ker...@lists.infradead.org; l...@boundarydevices.com; >>>> shawn...@kernel.org; johan...@sipsolutions.net; >>>> stillcompil...@gmail.com; sergei.shtyl...@cogentembedded.com; >>>> a...@arndb.de; Troy Kisky <troy.ki...@boundarydevices.com> >&g

RE: [PATCH net-next V2 03/16] net: fec: pass txq to fec_enet_tx_queue instead of queue_id

2016-03-03 Thread Fugang Duan
net; > >> stillcompil...@gmail.com; sergei.shtyl...@cogentembedded.com; > >> a...@arndb.de; Troy Kisky <troy.ki...@boundarydevices.com> > >> Subject: [PATCH net-next V2 03/16] net: fec: pass txq to > >> fec_enet_tx_queue instead of queue_id > >>

Re: [PATCH net-next V2 03/16] net: fec: pass txq to fec_enet_tx_queue instead of queue_id

2016-03-02 Thread Troy Kisky
t; <troy.ki...@boundarydevices.com> >> Subject: [PATCH net-next V2 03/16] net: fec: pass txq to fec_enet_tx_queue >> instead of queue_id >> >> queue_id is the qid member of struct bufdesc_prop. >> >> Signed-off-by: Troy Kisky <troy.ki...@boundarydevices.

RE: [PATCH net-next V2 03/16] net: fec: pass txq to fec_enet_tx_queue instead of queue_id

2016-03-02 Thread Fugang Duan
g.uk; linux-arm- > ker...@lists.infradead.org; l...@boundarydevices.com; shawn...@kernel.org; > johan...@sipsolutions.net; stillcompil...@gmail.com; > sergei.shtyl...@cogentembedded.com; a...@arndb.de; Troy Kisky > <troy.ki...@boundarydevices.com> > Subject: [PATCH n

Re: [PATCH net-next V2 03/16] net: fec: pass txq to fec_enet_tx_queue instead of queue_id

2016-03-01 Thread Troy Kisky
On 3/1/2016 3:26 PM, Zhi Li wrote: > On Tue, Mar 1, 2016 at 3:51 PM, Troy Kisky > wrote: >> True, but fec_txq/fec_rxq is called in a loop. > > netdev_priv(ndev) is that pointer move. > dev + ALIGN(sizeof(struct net_device), NETDEV_ALIGN) > > Modem compiler can

Re: [PATCH net-next V2 03/16] net: fec: pass txq to fec_enet_tx_queue instead of queue_id

2016-03-01 Thread Zhi Li
On Tue, Mar 1, 2016 at 3:51 PM, Troy Kisky wrote: > True, but fec_txq/fec_rxq is called in a loop. netdev_priv(ndev) is that pointer move. dev + ALIGN(sizeof(struct net_device), NETDEV_ALIGN) Modem compiler can handle it greatly. You can't get any valuable

Re: [PATCH net-next V2 03/16] net: fec: pass txq to fec_enet_tx_queue instead of queue_id

2016-03-01 Thread Troy Kisky
On 3/1/2016 2:06 PM, Zhi Li wrote: > On Wed, Feb 24, 2016 at 6:36 PM, Troy Kisky > wrote: >> queue_id is the qid member of struct bufdesc_prop. >> >> Signed-off-by: Troy Kisky >> --- >> drivers/net/ethernet/freescale/fec_main.c |

Re: [PATCH net-next V2 03/16] net: fec: pass txq to fec_enet_tx_queue instead of queue_id

2016-03-01 Thread Zhi Li
On Wed, Feb 24, 2016 at 6:36 PM, Troy Kisky wrote: > queue_id is the qid member of struct bufdesc_prop. > > Signed-off-by: Troy Kisky > --- > drivers/net/ethernet/freescale/fec_main.c | 17 ++--- > 1 file changed, 6

[PATCH net-next V2 03/16] net: fec: pass txq to fec_enet_tx_queue instead of queue_id

2016-02-24 Thread Troy Kisky
queue_id is the qid member of struct bufdesc_prop. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec_main.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c