Re: [PATCH net-next V3 3/7] net/sched: Reflect HW offload status

2017-02-16 Thread Jakub Kicinski
On Thu, 16 Feb 2017 10:17:44 +0200, Ido Schimmel wrote: > On Wed, Feb 15, 2017 at 10:28:21AM -0800, Jakub Kicinski wrote: > > What worries me is that the moment we started offloading packet > > modification we run at the risk of modifying packets twice. This used > > to be a problem only for eBPF

Re: [PATCH net-next V3 3/7] net/sched: Reflect HW offload status

2017-02-16 Thread Ido Schimmel
On Wed, Feb 15, 2017 at 10:28:21AM -0800, Jakub Kicinski wrote: > What worries me is that the moment we started offloading packet > modification we run at the risk of modifying packets twice. This used > to be a problem only for eBPF but now mlx5 can also offload things like > ttl decrement. For

Re: [PATCH net-next V3 3/7] net/sched: Reflect HW offload status

2017-02-15 Thread Jakub Kicinski
On Wed, 15 Feb 2017 23:56:53 +0200, Or Gerlitz wrote: > On Wed, Feb 15, 2017 at 8:28 PM, Jakub Kicinski > wrote: > > On Wed, 15 Feb 2017 18:19:17 +0200, Or Gerlitz wrote: > >> On Wed, Feb 15, 2017 at 10:52 AM, Or Gerlitz > >> wrote: > >>> Currently there is no way of querying whether a filte

Re: [PATCH net-next V3 3/7] net/sched: Reflect HW offload status

2017-02-15 Thread Or Gerlitz
On Wed, Feb 15, 2017 at 8:28 PM, Jakub Kicinski wrote: > On Wed, 15 Feb 2017 18:19:17 +0200, Or Gerlitz wrote: >> On Wed, Feb 15, 2017 at 10:52 AM, Or Gerlitz wrote: >>> Currently there is no way of querying whether a filter is >>> offloaded to HW or not when using "both" policy (where none >>> o

Re: [PATCH net-next V3 3/7] net/sched: Reflect HW offload status

2017-02-15 Thread Jakub Kicinski
On Wed, 15 Feb 2017 18:19:17 +0200, Or Gerlitz wrote: > On Wed, Feb 15, 2017 at 10:52 AM, Or Gerlitz wrote: > > Currently there is no way of querying whether a filter is > > offloaded to HW or not when using "both" policy (where none > > of skip_sw or skip_hw flags are set by user-space). > > >

Re: [PATCH net-next V3 3/7] net/sched: Reflect HW offload status

2017-02-15 Thread Or Gerlitz
On Wed, Feb 15, 2017 at 10:52 AM, Or Gerlitz wrote: > Currently there is no way of querying whether a filter is > offloaded to HW or not when using "both" policy (where none > of skip_sw or skip_hw flags are set by user-space). > Add two new flags, "in hw" and "not in hw" such that user > space c

[PATCH net-next V3 3/7] net/sched: Reflect HW offload status

2017-02-15 Thread Or Gerlitz
Currently there is no way of querying whether a filter is offloaded to HW or not when using "both" policy (where none of skip_sw or skip_hw flags are set by user-space). Add two new flags, "in hw" and "not in hw" such that user space can determine if a filter is actually offloaded to hw or not. Th