[PATCH net-next v2] bridge: also trigger RTM_NEWLINK when interface is released from bridge

2017-09-16 Thread Vincent Bernat
Currently, when an interface is released from a bridge via ioctl(), we get a RTM_DELLINK event through netlink: Deleted 2: dummy0: mtu 1500 master bridge0 state UNKNOWN link/ether 6e:23:c2:54:3a:b3 Userspace has to interpret that as a removal from the bridge, not as a complete removal of th

Re: [PATCH net-next v2] bridge: also trigger RTM_NEWLINK when interface is released from bridge

2017-09-20 Thread David Miller
From: Vincent Bernat Date: Sat, 16 Sep 2017 16:18:33 +0200 David, I am CC:'ing you because you've done work in this area over the past year. I'm applying this patch, it's been sitting since the 16th and likes entirely correct to me. But if you have objections just let me know. > Currently, whe

Re: [PATCH net-next v2] bridge: also trigger RTM_NEWLINK when interface is released from bridge

2017-09-20 Thread David Ahern
On 9/20/17 3:09 PM, David Miller wrote: > From: Vincent Bernat > Date: Sat, 16 Sep 2017 16:18:33 +0200 > > David, I am CC:'ing you because you've done work in this area over the > past year. I'm applying this patch, it's been sitting since the 16th > and likes entirely correct to me. But if you

Re: [PATCH net-next v2] bridge: also trigger RTM_NEWLINK when interface is released from bridge

2017-09-20 Thread Vincent Bernat
❦ 20 septembre 2017 15:57 -0600, David Ahern  : > The DELLINK is for AF_BRIDGE family (ifi_family). Adding family to > print_linkinfo and running the monitor I get: > > > [LINK]family 0: 35: dummy1: mtu 1500 qdisc > noqueue master br0 state UNKNOWN group default > link/ether d6:c3:73:86:3c:7

Re: [PATCH net-next v2] bridge: also trigger RTM_NEWLINK when interface is released from bridge

2017-09-20 Thread David Miller
From: Vincent Bernat Date: Thu, 21 Sep 2017 00:12:53 +0200 > ❦ 20 septembre 2017 15:57 -0600, David Ahern  : > >> The DELLINK is for AF_BRIDGE family (ifi_family). Adding family to >> print_linkinfo and running the monitor I get: >> >> >> [LINK]family 0: 35: dummy1: mtu 1500 qdisc >> noqueue m

Re: [PATCH net-next v2] bridge: also trigger RTM_NEWLINK when interface is released from bridge

2017-09-20 Thread Stephen Hemminger
On Wed, 20 Sep 2017 15:57:16 -0600 David Ahern wrote: > On 9/20/17 3:09 PM, David Miller wrote: > > From: Vincent Bernat > > Date: Sat, 16 Sep 2017 16:18:33 +0200 > > > > David, I am CC:'ing you because you've done work in this area over the > > past year. I'm applying this patch, it's been si

Re: [PATCH net-next v2] bridge: also trigger RTM_NEWLINK when interface is released from bridge

2017-09-21 Thread Vincent Bernat
❦ 20 septembre 2017 16:21 -0700, Stephen Hemminger  : > The one concern is that ports added or removed through ioctl should > cause same events as doing the same thing via netlink. Some users use > brctl (ioctl) and others use newer bridge (netlink) API. I'll make a third iteration to have the

Re: [PATCH net-next v2] bridge: also trigger RTM_NEWLINK when interface is released from bridge

2017-09-21 Thread Roopa Prabhu
On Thu, Sep 21, 2017 at 3:04 AM, Vincent Bernat wrote: > ❦ 20 septembre 2017 16:21 -0700, Stephen Hemminger > : > >> The one concern is that ports added or removed through ioctl should >> cause same events as doing the same thing via netlink. Some users use >> brctl (ioctl) and others use newer

Re: [PATCH net-next v2] bridge: also trigger RTM_NEWLINK when interface is released from bridge

2017-09-21 Thread Vincent Bernat
❦ 21 septembre 2017 08:09 -0700, Roopa Prabhu  : >>> The one concern is that ports added or removed through ioctl should >>> cause same events as doing the same thing via netlink. Some users use >>> brctl (ioctl) and others use newer bridge (netlink) API. >> >> I'll make a third iteration to have