Re: [PATCH net-next v2] net/packet: Fix a comment about hard_header_len and headroom allocation

2020-09-14 Thread David Miller
From: Xie He Date: Mon, 14 Sep 2020 00:41:54 -0700 > This comment is outdated and no longer reflects the actual implementation > of af_packet.c. > > Reasons for the new comment: > > 1. > > In af_packet.c, the function packet_snd first reserves a headroom of > length (dev->hard_header_len + dev

Re: [PATCH net-next v2] net/packet: Fix a comment about hard_header_len and headroom allocation

2020-09-14 Thread Willem de Bruijn
On Mon, Sep 14, 2020 at 9:42 AM Xie He wrote: > > This comment is outdated and no longer reflects the actual implementation > of af_packet.c. > > Reasons for the new comment: > > 1. > > In af_packet.c, the function packet_snd first reserves a headroom of > length (dev->hard_header_len + dev->neede

[PATCH net-next v2] net/packet: Fix a comment about hard_header_len and headroom allocation

2020-09-14 Thread Xie He
This comment is outdated and no longer reflects the actual implementation of af_packet.c. Reasons for the new comment: 1. In af_packet.c, the function packet_snd first reserves a headroom of length (dev->hard_header_len + dev->needed_headroom). Then if the socket is a SOCK_DGRAM socket, it calls