Re: [PATCH net-next v2] net: mvpp2: Don't use dynamic allocs for local variables

On Thu, 22 Mar 2018 15:43:08 -0400 (EDT), David Miller wrote : > From: Maxime Chevallier > Date: Thu, 22 Mar 2018 20:14:53 +0100 > > > Hello David, > > > > On Thu, 22 Mar 2018 14:47:09 -0400 (EDT), > > David Miller

Re: [PATCH net-next v2] net: mvpp2: Don't use dynamic allocs for local variables

From: Maxime Chevallier Date: Thu, 22 Mar 2018 20:14:53 +0100 > Hello David, > > On Thu, 22 Mar 2018 14:47:09 -0400 (EDT), > David Miller wrote : > >> From: Maxime Chevallier >> Date: Wed, 21 Mar 2018 16:14:00

Re: [PATCH net-next v2] net: mvpp2: Don't use dynamic allocs for local variables

Hello David, On Thu, 22 Mar 2018 14:47:09 -0400 (EDT), David Miller wrote : > From: Maxime Chevallier > Date: Wed, 21 Mar 2018 16:14:00 +0100 > > > diff --git a/drivers/net/ethernet/marvell/mvpp2.c > > b/drivers/net/ethernet/marvell/mvpp2.c

Re: [PATCH net-next v2] net: mvpp2: Don't use dynamic allocs for local variables

From: Maxime Chevallier Date: Wed, 21 Mar 2018 16:14:00 +0100 > diff --git a/drivers/net/ethernet/marvell/mvpp2.c > b/drivers/net/ethernet/marvell/mvpp2.c > index 9bd35f2291d6..28e33e139178 100644 > --- a/drivers/net/ethernet/marvell/mvpp2.c > +++

Re: [PATCH net-next v2] net: mvpp2: Don't use dynamic allocs for local variables

Hello Yan, On Wed, 21 Mar 2018 19:57:47 +, Yan Markman wrote : > Hi Maxime Please avoid top-posting on this list. > Please check the TWO points: > > 1). The mvpp2_prs_flow_find() returns TID if found > The TID=0 is valid FOUND value > For Not-found use

RE: [PATCH net-next v2] net: mvpp2: Don't use dynamic allocs for local variables

.@bootlin.com; Nadav Haklai <nad...@marvell.com>; Stefan Chulski <stef...@marvell.com>; Yan Markman <ymark...@marvell.com>; m...@semihalf.com Subject: [PATCH net-next v2] net: mvpp2: Don't use dynamic allocs for local variables Some helper functions that search for given entri

[PATCH net-next v2] net: mvpp2: Don't use dynamic allocs for local variables

Some helper functions that search for given entries in the TCAM filter on PPv2 controller make use of dynamically alloced temporary variables, allocated with GFP_KERNEL. These functions can be called in atomic context, and dynamic alloc is not really needed in these cases anyways. This commit