Re: [PATCH net-next v2 00/13] Change DSA's FDB API and perform switchdev cleanup

2017-08-06 Thread Arkadi Sharshevsky
On 08/04/2017 06:29 PM, Vivien Didelot wrote: > Hi Arkadi, Jiri, > > Jiri Pirko writes: > >>> It seems impossible currently to move the self to be the default, and >>> this introduces regression which you don't approve, so it seems few >>> options left: >>> >>> a) Leave two

Re: [PATCH net-next v2 00/13] Change DSA's FDB API and perform switchdev cleanup

2017-08-04 Thread Vivien Didelot
Hi Arkadi, Jiri, Jiri Pirko writes: >>It seems impossible currently to move the self to be the default, and >>this introduces regression which you don't approve, so it seems few >>options left: >> >>a) Leave two ways to add fdb, through the bridge (by using the master >>

Re: [PATCH net-next v2 00/13] Change DSA's FDB API and perform switchdev cleanup

2017-08-03 Thread Jiri Pirko
Fri, Aug 04, 2017 at 12:39:02AM CEST, arka...@mellanox.com wrote: > >[...] > >>> Now we have the "offload" read only flag, which is good to inform about >>> a successfully programmed hardware, but adds another level of complexity >>> to understand the interaction with the hardware. >>> >>> I think

Re: [PATCH net-next v2 00/13] Change DSA's FDB API and perform switchdev cleanup

2017-08-03 Thread Arkadi Sharshevsky
[...] >> Now we have the "offload" read only flag, which is good to inform about >> a successfully programmed hardware, but adds another level of complexity >> to understand the interaction with the hardware. >> >> I think iproute2 is getting more and more confusing. From what I >> understood,

Re: [PATCH net-next v2 00/13] Change DSA's FDB API and perform switchdev cleanup

2017-07-23 Thread Arkadi Sharshevsky
On 07/20/2017 07:26 PM, Vivien Didelot wrote: > Hi Arkadi, > > Arkadi Sharshevsky writes: > >> Hi, thanks for the test. If the fdb is marked as self its not in the >> bridge at all. So before my patch it was OK because you supported the >> self thing. >> >> Please notice

Re: [PATCH net-next v2 00/13] Change DSA's FDB API and perform switchdev cleanup

2017-07-20 Thread Vivien Didelot
Hi Arkadi, Arkadi Sharshevsky writes: > Hi, thanks for the test. If the fdb is marked as self its not in the > bridge at all. So before my patch it was OK because you supported the > self thing. > > Please notice that both fdbs you added are marked the same because the >

Re: [PATCH net-next v2 00/13] Change DSA's FDB API and perform switchdev cleanup

2017-07-20 Thread Arkadi Sharshevsky
On 07/19/2017 11:17 PM, Vivien Didelot wrote: > Hi Arkadi, > > I am testing your patch series the behavior changes suspiciously: > > # brctl show br0 > bridge name bridge id STP enabled interfaces > br0 8000.f6d5ef06ccdd no

Re: [PATCH net-next v2 00/13] Change DSA's FDB API and perform switchdev cleanup

2017-07-19 Thread Vivien Didelot
Hi Arkadi, I am testing your patch series the behavior changes suspiciously: # brctl show br0 bridge name bridge id STP enabled interfaces br0 8000.f6d5ef06ccdd no lan0 lan1

[PATCH net-next v2 00/13] Change DSA's FDB API and perform switchdev cleanup

2017-07-19 Thread Arkadi Sharshevsky
The patchset moves the DSA driver into learning static FDB entries via the switchdev notification chain rather then by using bridge bypass SELF flag. The DSA drivers cannot sync the software bridge with hardware learned entries and use the switchdev's implementation of bypass FDB dumping.