Re: [PATCH net-next v2 03/10] net: sched: extend Qdisc with rcu

2018-09-18 Thread David Miller
From: Vlad Buslov Date: Mon, 17 Sep 2018 10:17:33 +0300 > +struct Qdisc *qdisc_lookup_rcu(struct net_device *dev, u32 handle) > +{ > + struct Qdisc *q; > + struct netdev_queue *nq; Reverse christmas tree for the local variables, please.

[PATCH net-next v2 03/10] net: sched: extend Qdisc with rcu

2018-09-17 Thread Vlad Buslov
Currently, Qdisc API functions assume that users have rtnl lock taken. To implement rtnl unlocked classifiers update interface, Qdisc API must be extended with functions that do not require rtnl lock. Extend Qdisc structure with rcu. Implement special version of put function qdisc_put_unlocked()