Re: [PATCH net-next v2 1/1] driver: ipvlan: Free ipvl_port directly with kfree instead of kfree_rcu

2016-12-06 Thread Gao Feng
Hi Eric, On Tue, Dec 6, 2016 at 11:18 PM, Eric Dumazet wrote: > On Tue, 2016-12-06 at 21:54 +0800, f...@ikuai8.com wrote: >> From: Gao Feng >> >> There is no one which may reference the ipvlan port when free it in >> ipvlan_port_create and

Re: [PATCH net-next v2 1/1] driver: ipvlan: Free ipvl_port directly with kfree instead of kfree_rcu

2016-12-06 Thread Eric Dumazet
On Tue, 2016-12-06 at 21:54 +0800, f...@ikuai8.com wrote: > From: Gao Feng > > There is no one which may reference the ipvlan port when free it in > ipvlan_port_create and ipvlan_port_destroy. So it is unnecessary to > use kfree_rcu. You did not really explain _why_ it was

[PATCH net-next v2 1/1] driver: ipvlan: Free ipvl_port directly with kfree instead of kfree_rcu

2016-12-06 Thread fgao
From: Gao Feng There is no one which may reference the ipvlan port when free it in ipvlan_port_create and ipvlan_port_destroy. So it is unnecessary to use kfree_rcu. Signed-off-by: Gao Feng --- v2: Remove the rcu of ipvl_port directly v1: Initial