This patch changes the code style to make the code more simple.
also removes the once used HNADEL_TX_MSG macro, according to the
review comments from Joe Perches.
Signed-off-by: huangdaode
Reviewed-by: Joe Perches
---
drivers/net/ethernet/hisilicon/hns/hnae.c | 45 +++---
Hello Huang.
On Mon, 2015-10-12 at 11:23 +0800, huangdaode wrote:
> This patch changes the code style to make the code more simple.
> also removes the once used HNADEL_TX_MSG macro, according to the
HANDEL_TX_MSG typo
> review comments from Joe Perches.
>
> Signed-off-by: huangdaode
> Reviewed
On 2015/10/12 11:24, Joe Perches wrote:
Hello Huang.
On Mon, 2015-10-12 at 11:23 +0800, huangdaode wrote:
This patch changes the code style to make the code more simple.
also removes the once used HNADEL_TX_MSG macro, according to the
HANDEL_TX_MSG typo
review comments from Joe Perches.
Sig
On Monday 12 October 2015 11:38:24 huangdaode wrote:
> On 2015/10/12 11:24, Joe Perches wrote:
> > Hello Huang.
> >
> > On Mon, 2015-10-12 at 11:23 +0800, huangdaode wrote:
> >> This patch changes the code style to make the code more simple.
> >> also removes the once used HNADEL_TX_MSG macro, acco
On Monday 12 October 2015 11:23:44 huangdaode wrote:
> + s += sprintf(s,
> + "\t\ttx_ring on
> %p:%u,%u,%u,%u,%u,%llu,%llu\n",
> + h->qs[i]->tx_ring.io_base,
> + h->qs[i]->tx
On Mon, 2015-10-12 at 13:59 +0200, Arnd Bergmann wrote:
> On Monday 12 October 2015 11:23:44 huangdaode wrote:
> > + s += sprintf(s,
> > + "\t\ttx_ring on
> > %p:%u,%u,%u,%u,%u,%llu,%llu\n",
> > + h->qs[i]->t
On Tue, Oct 13, 2015 at 03:06:21PM +0800, huangdaode wrote:
> Date: Tue, 13 Oct 2015 15:06:21 +0800
> From: huangdaode
> To: Kenneth Lee
> Subject: Fwd: Re: [PATCH net-next v2 1/2] hisilicon net: removes the once
> HANDEL_TX_MSG macro
> Message-ID: <561cad6d.
On Tuesday 13 October 2015 21:27:12 Kenneth Lee wrote:
>
> Hi, Arnd,
>
> Thank you for the comment. Yes, the io_base is a security problem, we
> will fix it in coming patch soon.
>
> But can we keep the sysfs? The interface from hnae is not used only by
> ethernet driver but also by Open Data Pl
om,
> salil.me...@huawei.com, kenneth-lee-2...@foxmail.com,
> xuw...@hisilicon.com, lisheng...@huawei.com, linux-ker...@vger.kernel.org,
> huangdaode
> Subject: Re: Fwd: Re: [PATCH net-next v2 1/2] hisilicon net: removes the
> once HANDEL_TX_MSG macro
> Message-ID: <6914069
