Re: [PATCH net-next v2 1/5] net: Introduce NETIF_F_GRO_HW.

2017-12-07 Thread Michael Chan
On Thu, Dec 7, 2017 at 6:36 PM, Alexander Duyck wrote: > On Thu, Dec 7, 2017 at 4:05 PM, Michael Chan > wrote: >> I see. But this won't happen. Because the bonding driver is not >> advertising NETIF_F_GRO_HW in its hw_features. It is not

Re: [PATCH net-next v2 1/5] net: Introduce NETIF_F_GRO_HW.

2017-12-07 Thread Alexander Duyck
On Thu, Dec 7, 2017 at 4:05 PM, Michael Chan wrote: > On Thu, Dec 7, 2017 at 3:35 PM, Alexander Duyck > wrote: >> On Thu, Dec 7, 2017 at 3:17 PM, Michael Chan >> wrote: >>> I don't get this. I don't see how TSO

Re: [PATCH net-next v2 1/5] net: Introduce NETIF_F_GRO_HW.

2017-12-07 Thread Michael Chan
On Thu, Dec 7, 2017 at 3:35 PM, Alexander Duyck wrote: > On Thu, Dec 7, 2017 at 3:17 PM, Michael Chan > wrote: >> I don't get this. I don't see how TSO is related. > > It isn't. That is the point. If I change ANY feature it will trigger >

Re: [PATCH net-next v2 1/5] net: Introduce NETIF_F_GRO_HW.

2017-12-07 Thread Alexander Duyck
On Thu, Dec 7, 2017 at 3:17 PM, Michael Chan wrote: > On Thu, Dec 7, 2017 at 2:43 PM, Alexander Duyck > wrote: >> On Thu, Dec 7, 2017 at 2:08 PM, Michael Chan >> wrote: >>> On the bond, you can have LRO enabled

Re: [PATCH net-next v2 1/5] net: Introduce NETIF_F_GRO_HW.

2017-12-07 Thread Michael Chan
On Thu, Dec 7, 2017 at 2:43 PM, Alexander Duyck wrote: > On Thu, Dec 7, 2017 at 2:08 PM, Michael Chan > wrote: >> On the bond, you can have LRO enabled and it is propagated to lower >> devices so that lower devices will enable LRO if it is

Re: [PATCH net-next v2 1/5] net: Introduce NETIF_F_GRO_HW.

2017-12-07 Thread Alexander Duyck
On Thu, Dec 7, 2017 at 2:08 PM, Michael Chan wrote: > On Thu, Dec 7, 2017 at 1:35 PM, Alexander Duyck > wrote: >> On Thu, Dec 7, 2017 at 10:44 AM, Michael Chan >> wrote: >>> On Thu, Dec 7, 2017 at 10:13 AM,

Re: [PATCH net-next v2 1/5] net: Introduce NETIF_F_GRO_HW.

2017-12-07 Thread Michael Chan
On Thu, Dec 7, 2017 at 1:35 PM, Alexander Duyck wrote: > On Thu, Dec 7, 2017 at 10:44 AM, Michael Chan > wrote: >> On Thu, Dec 7, 2017 at 10:13 AM, Alexander Duyck >> wrote: >>> On Thu, Dec 7, 2017 at 12:03 AM,

Re: [PATCH net-next v2 1/5] net: Introduce NETIF_F_GRO_HW.

2017-12-07 Thread Michael Chan
On Thu, Dec 7, 2017 at 10:13 AM, Alexander Duyck wrote: > On Thu, Dec 7, 2017 at 12:03 AM, Michael Chan > wrote: >> @@ -7405,6 +7405,23 @@ static netdev_features_t netdev_fix_features(struct >> net_device *dev, >> features

Re: [PATCH net-next v2 1/5] net: Introduce NETIF_F_GRO_HW.

2017-12-07 Thread Alexander Duyck
On Thu, Dec 7, 2017 at 12:03 AM, Michael Chan wrote: > Introduce NETIF_F_GRO_HW feature flag for NICs that support hardware > GRO. With this flag, we can now independently turn on or off hardware > GRO when GRO is on. Previously, drivers were using NETIF_F_GRO to >

[PATCH net-next v2 1/5] net: Introduce NETIF_F_GRO_HW.

2017-12-07 Thread Michael Chan
Introduce NETIF_F_GRO_HW feature flag for NICs that support hardware GRO. With this flag, we can now independently turn on or off hardware GRO when GRO is on. Previously, drivers were using NETIF_F_GRO to control hardware GRO and so it cannot be independently turned on or off without affecting