Re: [PATCH net-next v2 1/7] net: devlink: Add unused port flavour

2020-10-01 Thread Jiri Pirko
Wed, Sep 30, 2020 at 04:53:57PM CEST, and...@lunn.ch wrote: >> What do you mean by "regions"? Devlink regions? They are per-device, not >> per-port. I have to be missing something. > >The rest of the patch series, which add regions per port! This came Okay. Sorry about that. netdev ml kicked me ou

Re: [PATCH net-next v2 1/7] net: devlink: Add unused port flavour

2020-09-30 Thread Andrew Lunn
> What do you mean by "regions"? Devlink regions? They are per-device, not > per-port. I have to be missing something. The rest of the patch series, which add regions per port! This came out of the discussion from the first version of this patchset, and Jakub said it would make sense to add per po

Re: [PATCH net-next v2 1/7] net: devlink: Add unused port flavour

2020-09-30 Thread Jiri Pirko
Wed, Sep 30, 2020 at 03:57:25PM CEST, and...@lunn.ch wrote: >> I get it. But I as I wrote previously, I wonder if used/unused should >> not be another attribute. Then the flavour can be "undefined". > >In the DSA world, it is not undefined. It is clear defined as >unused. And it cannot be on-the-fl

Re: [PATCH net-next v2 1/7] net: devlink: Add unused port flavour

2020-09-30 Thread Andrew Lunn
> I get it. But I as I wrote previously, I wonder if used/unused should > not be another attribute. Then the flavour can be "undefined". In the DSA world, it is not undefined. It is clear defined as unused. And it cannot be on-the-fly changed. It is a property of the PCB, in that the pins exist on

Re: [PATCH net-next v2 1/7] net: devlink: Add unused port flavour

2020-09-29 Thread Jiri Pirko
Tue, Sep 29, 2020 at 03:57:00PM CEST, and...@lunn.ch wrote: >On Tue, Sep 29, 2020 at 03:07:58PM +0200, Jiri Pirko wrote: >> Tue, Sep 29, 2020 at 01:03:56PM CEST, vladimir.olt...@nxp.com wrote: >> >On Mon, Sep 28, 2020 at 06:46:14PM -0700, Florian Fainelli wrote: >> >> That makes sense to me as it w

Re: [PATCH net-next v2 1/7] net: devlink: Add unused port flavour

2020-09-29 Thread Jiri Pirko
Tue, Sep 29, 2020 at 03:48:56PM CEST, vladimir.olt...@nxp.com wrote: >On Tue, Sep 29, 2020 at 03:07:58PM +0200, Jiri Pirko wrote: >> Tue, Sep 29, 2020 at 01:03:56PM CEST, vladimir.olt...@nxp.com wrote: >> >On Mon, Sep 28, 2020 at 06:46:14PM -0700, Florian Fainelli wrote: >> >> That makes sense to m

Re: [PATCH net-next v2 1/7] net: devlink: Add unused port flavour

2020-09-29 Thread Andrew Lunn
On Tue, Sep 29, 2020 at 03:07:58PM +0200, Jiri Pirko wrote: > Tue, Sep 29, 2020 at 01:03:56PM CEST, vladimir.olt...@nxp.com wrote: > >On Mon, Sep 28, 2020 at 06:46:14PM -0700, Florian Fainelli wrote: > >> That makes sense to me as it would be confusing to suddenly show unused > >> port > >> flavor

Re: [PATCH net-next v2 1/7] net: devlink: Add unused port flavour

2020-09-29 Thread Vladimir Oltean
On Tue, Sep 29, 2020 at 03:07:58PM +0200, Jiri Pirko wrote: > Tue, Sep 29, 2020 at 01:03:56PM CEST, vladimir.olt...@nxp.com wrote: > >On Mon, Sep 28, 2020 at 06:46:14PM -0700, Florian Fainelli wrote: > >> That makes sense to me as it would be confusing to suddenly show unused > >> port > >> flavor

Re: [PATCH net-next v2 1/7] net: devlink: Add unused port flavour

2020-09-29 Thread Jiri Pirko
Tue, Sep 29, 2020 at 01:03:56PM CEST, vladimir.olt...@nxp.com wrote: >On Mon, Sep 28, 2020 at 06:46:14PM -0700, Florian Fainelli wrote: >> That makes sense to me as it would be confusing to suddenly show unused port >> flavors after this patch series land. Andrew, Vladimir, does that work for >> yo

Re: [PATCH net-next v2 1/7] net: devlink: Add unused port flavour

2020-09-29 Thread Vladimir Oltean
On Mon, Sep 28, 2020 at 06:46:14PM -0700, Florian Fainelli wrote: > That makes sense to me as it would be confusing to suddenly show unused port > flavors after this patch series land. Andrew, Vladimir, does that work for > you as well? I have nothing to object against somebody adding a '--all' ar

Re: [PATCH net-next v2 1/7] net: devlink: Add unused port flavour

2020-09-28 Thread Florian Fainelli
On 9/28/2020 4:39 PM, Jakub Kicinski wrote: On Mon, 28 Sep 2020 15:36:50 -0700 Florian Fainelli wrote: On 9/28/2020 3:35 PM, Jakub Kicinski wrote: On Tue, 29 Sep 2020 00:07:30 +0200 Andrew Lunn wrote: On Mon, Sep 28, 2020 at 10:05:08PM +, Vladimir Oltean wrote: On Mon, Sep 28, 2020 at

Re: [PATCH net-next v2 1/7] net: devlink: Add unused port flavour

2020-09-28 Thread Jakub Kicinski
On Tue, 29 Sep 2020 00:07:30 +0200 Andrew Lunn wrote: > On Mon, Sep 28, 2020 at 10:05:08PM +, Vladimir Oltean wrote: > > On Mon, Sep 28, 2020 at 02:31:55PM -0700, Jakub Kicinski wrote: > > > On Sat, 26 Sep 2020 23:06:26 +0200 Andrew Lunn wrote: > > > > Not all ports of a switch need to be u

Re: [PATCH net-next v2 1/7] net: devlink: Add unused port flavour

2020-09-28 Thread Jakub Kicinski
On Mon, 28 Sep 2020 15:36:50 -0700 Florian Fainelli wrote: > On 9/28/2020 3:35 PM, Jakub Kicinski wrote: > > On Tue, 29 Sep 2020 00:07:30 +0200 Andrew Lunn wrote: > >> On Mon, Sep 28, 2020 at 10:05:08PM +, Vladimir Oltean wrote: > >>> On Mon, Sep 28, 2020 at 02:31:55PM -0700, Jakub Kicinski

Re: [PATCH net-next v2 1/7] net: devlink: Add unused port flavour

2020-09-28 Thread Vladimir Oltean
On Mon, Sep 28, 2020 at 02:31:55PM -0700, Jakub Kicinski wrote: > On Sat, 26 Sep 2020 23:06:26 +0200 Andrew Lunn wrote: > > Not all ports of a switch need to be used, particularly in embedded > > systems. Add a port flavour for ports which physically exist in the > > switch, but are not connected t

Re: [PATCH net-next v2 1/7] net: devlink: Add unused port flavour

2020-09-28 Thread Florian Fainelli
On 9/28/2020 3:35 PM, Jakub Kicinski wrote: On Tue, 29 Sep 2020 00:07:30 +0200 Andrew Lunn wrote: On Mon, Sep 28, 2020 at 10:05:08PM +, Vladimir Oltean wrote: On Mon, Sep 28, 2020 at 02:31:55PM -0700, Jakub Kicinski wrote: On Sat, 26 Sep 2020 23:06:26 +0200 Andrew Lunn wrote: Not all p

Re: [PATCH net-next v2 1/7] net: devlink: Add unused port flavour

2020-09-28 Thread Andrew Lunn
On Mon, Sep 28, 2020 at 10:05:08PM +, Vladimir Oltean wrote: > On Mon, Sep 28, 2020 at 02:31:55PM -0700, Jakub Kicinski wrote: > > On Sat, 26 Sep 2020 23:06:26 +0200 Andrew Lunn wrote: > > > Not all ports of a switch need to be used, particularly in embedded > > > systems. Add a port flavour fo

Re: [PATCH net-next v2 1/7] net: devlink: Add unused port flavour

2020-09-28 Thread Jakub Kicinski
On Sat, 26 Sep 2020 23:06:26 +0200 Andrew Lunn wrote: > Not all ports of a switch need to be used, particularly in embedded > systems. Add a port flavour for ports which physically exist in the > switch, but are not connected to the front panel etc, and so are > unused. This is missing the explana

Re: [PATCH net-next v2 1/7] net: devlink: Add unused port flavour

2020-09-26 Thread Andrew Lunn
On Sun, Sep 27, 2020 at 01:00:34AM +0300, Vladimir Oltean wrote: > On Sat, Sep 26, 2020 at 11:06:26PM +0200, Andrew Lunn wrote: > > Not all ports of a switch need to be used, particularly in embedded > > systems. Add a port flavour for ports which physically exist in the > > switch, but are not con

Re: [PATCH net-next v2 1/7] net: devlink: Add unused port flavour

2020-09-26 Thread Vladimir Oltean
On Sat, Sep 26, 2020 at 11:06:26PM +0200, Andrew Lunn wrote: > Not all ports of a switch need to be used, particularly in embedded > systems. Add a port flavour for ports which physically exist in the > switch, but are not connected to the front panel etc, and so are > unused. > > Signed-off-by: A

Re: [PATCH net-next v2 1/7] net: devlink: Add unused port flavour

2020-09-26 Thread Vladimir Oltean
On Sat, Sep 26, 2020 at 11:06:26PM +0200, Andrew Lunn wrote: > Not all ports of a switch need to be used, particularly in embedded > systems. Add a port flavour for ports which physically exist in the > switch, but are not connected to the front panel etc, and so are > unused. > > Signed-off-by: A

[PATCH net-next v2 1/7] net: devlink: Add unused port flavour

2020-09-26 Thread Andrew Lunn
Not all ports of a switch need to be used, particularly in embedded systems. Add a port flavour for ports which physically exist in the switch, but are not connected to the front panel etc, and so are unused. Signed-off-by: Andrew Lunn --- include/uapi/linux/devlink.h | 3 +++ net/core/devlink.c