On Wed, Mar 30, 2016 at 12:58:04AM +, Patrick Uiterwijk wrote:
> Hi Vivien,
>
> On Tue, Mar 29, 2016 at 6:49 PM, Vivien Didelot
> wrote:
> > Hi Andrew, Patrick,
> >
> > Andrew Lunn writes:
> >
> >> On Tue, Mar 29, 2016 at 12:23:06PM -0400, Vivien Didelot wrote:
> >>> Hi Patrick,
> >>>
> >>>
Hi Vivien,
On Tue, Mar 29, 2016 at 6:49 PM, Vivien Didelot
wrote:
> Hi Andrew, Patrick,
>
> Andrew Lunn writes:
>
>> On Tue, Mar 29, 2016 at 12:23:06PM -0400, Vivien Didelot wrote:
>>> Hi Patrick,
>>>
>>> Two comments below.
>>>
>>> Patrick Uiterwijk writes:
>>>
>>> > +static int mv88e6xxx_powe
Hi Andrew, Patrick,
Andrew Lunn writes:
> On Tue, Mar 29, 2016 at 12:23:06PM -0400, Vivien Didelot wrote:
>> Hi Patrick,
>>
>> Two comments below.
>>
>> Patrick Uiterwijk writes:
>>
>> > +static int mv88e6xxx_power_on_serdes(struct dsa_switch *ds)
>>
>> Since this function assumes the SMI l
On Tue, Mar 29, 2016 at 12:23:06PM -0400, Vivien Didelot wrote:
> Hi Patrick,
>
> Two comments below.
>
> Patrick Uiterwijk writes:
>
> > +static int mv88e6xxx_power_on_serdes(struct dsa_switch *ds)
>
> Since this function assumes the SMI lock is already held, its name
> should be prefixed wit
Hi Patrick,
Two comments below.
Patrick Uiterwijk writes:
> +static int mv88e6xxx_power_on_serdes(struct dsa_switch *ds)
Since this function assumes the SMI lock is already held, its name
should be prefixed with _ by convention (_mv88e6xxx_power_on_serdes).
> +{
> + int ret;
> +
> + r
Some of the vendor-specific bootloaders set up this part
of the initialization for us, so this was never added.
However, since upstream bootloaders don't initialize the
chip specifically, they leave the fiber MII's PDOWN flag
set, which means that the CPU port doesn't connect.
This patch checks wh
