Re: [PATCH net-next v3 03/17] net: ethtool: add new ETHTOOL_GSETTINGS/SSETTINGS API

From: David Decotigny Date: Tue, 1 Dec 2015 22:00:58 -0800 > There is a set of conversion routines ulong[]<->u32[] to address this > 32/64-bit compat issue. And it's extremely ugly. There is nothing stopping you from adding bitmap_set32() et al. helpers to facilitate

Re: [PATCH net-next v3 03/17] net: ethtool: add new ETHTOOL_GSETTINGS/SSETTINGS API

From: David Decotigny Date: Mon, 30 Nov 2015 14:05:41 -0800 > This patch defines a new ETHTOOL_GSETTINGS/SSETTINGS API, handled by > the new get_ksettings/set_ksettings callbacks. This API provides > support for most legacy ethtool_cmd fields, adds support for larger > link

Re: [PATCH net-next v3 03/17] net: ethtool: add new ETHTOOL_GSETTINGS/SSETTINGS API

Hello, There is a set of conversion routines ulong[]<->u32[] to address this 32/64-bit compat issue. Using a u32-based bitmap would require drivers to handle the u32 bitmaps themselves, this might be confusing, considering there is a standard bitmap api; and might be error-prone as well. Plus

[PATCH net-next v3 03/17] net: ethtool: add new ETHTOOL_GSETTINGS/SSETTINGS API

From: David Decotigny This patch defines a new ETHTOOL_GSETTINGS/SSETTINGS API, handled by the new get_ksettings/set_ksettings callbacks. This API provides support for most legacy ethtool_cmd fields, adds support for larger link mode masks (up to 4064 bits, variable length),

Re: [PATCH net-next v3 03/17] net: ethtool: add new ETHTOOL_GSETTINGS/SSETTINGS API

On Mon, 2015-11-30 at 14:05 -0800, David Decotigny wrote: > From: David Decotigny > > This patch defines a new ETHTOOL_GSETTINGS/SSETTINGS API, handled by > the new get_ksettings/set_ksettings callbacks. This API provides > support for most legacy ethtool_cmd fields, adds

Re: [PATCH net-next v3 03/17] net: ethtool: add new ETHTOOL_GSETTINGS/SSETTINGS API

Hi David, [auto build test WARNING on: net-next/master] [also build test WARNING on: v4.4-rc3 next-20151127] url: https://github.com/0day-ci/linux/commits/David-Decotigny/RFC-new-ETHTOOL_GSETTINGS-SSETTINGS-API/20151201-062040 config: blackfin-allyesconfig (attached as .config) reproduce:

Re: [PATCH net-next v3 03/17] net: ethtool: add new ETHTOOL_GSETTINGS/SSETTINGS API

On Mon, Nov 30, 2015 at 4:04 PM, kbuild test robot wrote: >>> include/linux/ethtool.h:129:3: warning: comparison of unsigned expression >>> >= 0 is always true [-Wtype-limits] prepared a fix for that, will be part of next patch update after feedback. -- To unsubscribe from this