Re: [PATCH net-next v3 06/10] bnxt: Add devlink support for config get/set

2017-10-24 Thread Michael Chan
On Tue, Oct 24, 2017 at 10:55 PM, Yuval Mintz wrote: > ... > >> - if (!pci_find_ext_capability(bp->pdev, PCI_EXT_CAP_ID_SRIOV)) >> - return 0; >> - >> - if (bp->hwrm_spec_code < 0x10800) { >> + if ((!pci_find_ext_capability(bp->pdev, PCI_EXT_CAP_ID_SRIOV)) || >> +

RE: [PATCH net-next v3 06/10] bnxt: Add devlink support for config get/set

2017-10-24 Thread Yuval Mintz
> +static int bnxt_nvm_read(struct bnxt *bp, int nvm_param, int idx, > + void *buf, int size) > +{ > + struct hwrm_nvm_get_variable_input req = {0}; > + dma_addr_t dest_data_dma_addr; > + void *dest_data_addr = NULL; > + int bytesize; > + int rc; > + > +

Re: [PATCH net-next v3 06/10] bnxt: Add devlink support for config get/set

2017-10-24 Thread Steve Lin
On Tue, Oct 24, 2017 at 4:52 PM, Michael Chan wrote: > On Tue, Oct 24, 2017 at 1:12 PM, Steve Lin wrote: >> Implements get and set of configuration parameters using new devlink >> config get/set API. Parameters themselves defined in later patches. >> >> Signed-off-by: Steve Lin >> Acked-by: And

Re: [PATCH net-next v3 06/10] bnxt: Add devlink support for config get/set

2017-10-24 Thread Michael Chan
On Tue, Oct 24, 2017 at 1:12 PM, Steve Lin wrote: > Implements get and set of configuration parameters using new devlink > config get/set API. Parameters themselves defined in later patches. > > Signed-off-by: Steve Lin > Acked-by: Andy Gospodarek > --- > drivers/net/ethernet/broadcom/bnxt/bnx

[PATCH net-next v3 06/10] bnxt: Add devlink support for config get/set

2017-10-24 Thread Steve Lin
Implements get and set of configuration parameters using new devlink config get/set API. Parameters themselves defined in later patches. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek --- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 262 +- drivers/net/ethernet/b