Re: [PATCH net-next v3 2/3] nsh: logging module

2016-03-04 Thread Brian Russell
On 01/03/16 18:25, Joe Perches wrote: > On Tue, 2016-03-01 at 11:11 +, Brian Russell wrote: >> Module can register for Type 1 or specified classes of Type 2 metadata >> and will then log incoming matching packets. > > This logging mechanism seems like a way to fill/DoS logs. > > Maybe use p

Re: [PATCH net-next v3 2/3] nsh: logging module

2016-03-01 Thread Joe Perches
On Tue, 2016-03-01 at 11:11 +, Brian Russell wrote: > Module can register for Type 1 or specified classes of Type 2 metadata > and will then log incoming matching packets. This logging mechanism seems like a way to fill/DoS logs. Maybe use pr_info_ratelimit? Maybe use the trace_events mechani

[PATCH net-next v3 2/3] nsh: logging module

2016-03-01 Thread Brian Russell
Module can register for Type 1 or specified classes of Type 2 metadata and will then log incoming matching packets. Signed-off-by: Brian Russell --- net/ipv4/Kconfig | 8 net/ipv4/Makefile | 1 + net/ipv4/nsh_log.c | 135 + 3 files