Re: [PATCH net-next v4 0/5] Introduce NETIF_F_GRO_HW

2017-12-14 Thread Or Gerlitz
On Thu, Dec 14, 2017 at 8:36 PM, Michael Chan wrote: > On Thu, Dec 14, 2017 at 8:34 AM, Or Gerlitz wrote: >> On Mon, Dec 11, 2017 at 1:41 PM, Michael Chan >> wrote: >>> Introduce NETIF_F_GRO_HW feature flag and convert

Re: [PATCH net-next v4 0/5] Introduce NETIF_F_GRO_HW

2017-12-14 Thread Michael Chan
On Thu, Dec 14, 2017 at 8:34 AM, Or Gerlitz wrote: > On Mon, Dec 11, 2017 at 1:41 PM, Michael Chan > wrote: >> Introduce NETIF_F_GRO_HW feature flag and convert drivers that support >> hardware GRO to use the new flag. > > Hi Michael, > > Could

Re: [PATCH net-next v4 0/5] Introduce NETIF_F_GRO_HW

2017-12-14 Thread Or Gerlitz
On Mon, Dec 11, 2017 at 1:41 PM, Michael Chan wrote: > Introduce NETIF_F_GRO_HW feature flag and convert drivers that support > hardware GRO to use the new flag. Hi Michael, Could you add more performance motivations/results? looking on your netconf slides [1] I see

[PATCH net-next v4 0/5] Introduce NETIF_F_GRO_HW

2017-12-11 Thread Michael Chan
Introduce NETIF_F_GRO_HW feature flag and convert drivers that support hardware GRO to use the new flag. v4: - more changes requested by Alexander Duyck: - check GRO_HW/GRO dependency in drivers's ndo_fix_features(). - Reverse the order of RXCSUM and GRO_HW dependency check in