Re: [PATCH net-next v5 06/10] bridge: cfm: Kernel space implementation of CFM. CCM frame RX added.

2020-10-15 Thread Henrik Bjoernlund
Thanks for your review. Comments below. Regards Henrik The 10/14/2020 16:16, Jakub Kicinski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Mon, 12 Oct 2020 14:04:24 + Henrik Bjoernlund wrote: > > +struct br_cfm_status_tlv { > > +

Re: [PATCH net-next v5 06/10] bridge: cfm: Kernel space implementation of CFM. CCM frame RX added.

2020-10-15 Thread Henrik Bjoernlund
Thanks for your review. Comments below. Regards Henrik The 10/14/2020 16:26, Jakub Kicinski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Mon, 12 Oct 2020 14:04:24 + Henrik Bjoernlund wrote: > > + /* This CCM related status i

Re: [PATCH net-next v5 06/10] bridge: cfm: Kernel space implementation of CFM. CCM frame RX added.

2020-10-14 Thread Jakub Kicinski
On Mon, 12 Oct 2020 14:04:24 + Henrik Bjoernlund wrote: > + /* This CCM related status is based on the latest received CCM PDU. */ > + u8 port_tlv_value; /* Port Status TLV value */ > + u8 if_tlv_value; /* Interface Status TLV value */ > + > + /* CCM has not been received for 3.

Re: [PATCH net-next v5 06/10] bridge: cfm: Kernel space implementation of CFM. CCM frame RX added.

2020-10-14 Thread Jakub Kicinski
On Mon, 12 Oct 2020 14:04:24 + Henrik Bjoernlund wrote: > +struct br_cfm_status_tlv { > + __u8 type; > + __be16 length; > + __u8 value; > +}; This structure is unused (and likely not what you want, since it will have 2 1 byte while unless you mark length as __packed).

[PATCH net-next v5 06/10] bridge: cfm: Kernel space implementation of CFM. CCM frame RX added.

2020-10-12 Thread Henrik Bjoernlund
This is the third commit of the implementation of the CFM protocol according to 802.1Q section 12.14. Functionality is extended with CCM frame reception. The MEP instance now contains CCM based status information. Most important is the CCM defect status indicating if correct CCM frames are receive