Re: [PATCH net-next v6] net: psample: Introduce stubs to remove NIC driver dependency

2021-02-02 Thread Chris Mi
Hi Jakub, On 2/3/2021 5:24 AM, Jakub Kicinski wrote: On Mon, 01 Feb 2021 23:31:15 -0800 Saeed Mahameed wrote: On Mon, 2021-02-01 at 17:14 -0800, Jakub Kicinski wrote: On Mon,  1 Feb 2021 10:04:12 +0800 Chris Mi wrote: In order to send sampled packets to userspace, NIC driver calls psample api

Re: [PATCH net-next v6] net: psample: Introduce stubs to remove NIC driver dependency

2021-02-02 Thread Saeed Mahameed
On Tue, 2021-02-02 at 13:24 -0800, Jakub Kicinski wrote: > On Mon, 01 Feb 2021 23:31:15 -0800 Saeed Mahameed wrote: ... > > > > Jakub, it is not only about installation dependencies, the issue is > > more critical than this, > > > > We had some other issues with similar dependency problem wher

Re: [PATCH net-next v6] net: psample: Introduce stubs to remove NIC driver dependency

2021-02-02 Thread Jakub Kicinski
On Mon, 01 Feb 2021 23:31:15 -0800 Saeed Mahameed wrote: > On Mon, 2021-02-01 at 17:14 -0800, Jakub Kicinski wrote: > > On Mon,  1 Feb 2021 10:04:12 +0800 Chris Mi wrote: > > > In order to send sampled packets to userspace, NIC driver calls > > > psample api directly. But it creates a hard depend

Re: [PATCH net-next v6] net: psample: Introduce stubs to remove NIC driver dependency

2021-02-01 Thread Saeed Mahameed
On Mon, 2021-02-01 at 17:14 -0800, Jakub Kicinski wrote: > On Mon,  1 Feb 2021 10:04:12 +0800 Chris Mi wrote: > > In order to send sampled packets to userspace, NIC driver calls > > psample api directly. But it creates a hard dependency on module > > psample. Introduce psample_ops to remove the har

Re: [PATCH net-next v6] net: psample: Introduce stubs to remove NIC driver dependency

2021-02-01 Thread Jakub Kicinski
On Mon, 1 Feb 2021 10:04:12 +0800 Chris Mi wrote: > In order to send sampled packets to userspace, NIC driver calls > psample api directly. But it creates a hard dependency on module > psample. Introduce psample_ops to remove the hard dependency. > It is initialized when psample module is loaded a

[PATCH net-next v6] net: psample: Introduce stubs to remove NIC driver dependency

2021-01-31 Thread Chris Mi
In order to send sampled packets to userspace, NIC driver calls psample api directly. But it creates a hard dependency on module psample. Introduce psample_ops to remove the hard dependency. It is initialized when psample module is loaded and set to NULL when the module is unloaded. Reported-by: k