Re: [PATCH net-next v7 1/3] vmcore: add API to collect hardware dump in second kernel

On Tue, 1 May 2018 23:57:45 +0530 Rahul Lakkireddy wrote: > + > +int vmcore_add_device_dump(struct vmcoredd_data *data) > +{ > + return __vmcore_add_device_dump(data); > +} > +EXPORT_SYMBOL(vmcore_add_device_dump); > +#endif /* CONFIG_PROC_VMCORE_DEVICE_DUMP

Re: [PATCH net-next v7 1/3] vmcore: add API to collect hardware dump in second kernel

Rahul Lakkireddy writes: > The sequence of actions done by device drivers to append their device > specific hardware/firmware logs to /proc/vmcore are as follows: Except for the missing include that the kbuild test robot caught I am not seeing a problems.

Re: [PATCH net-next v7 1/3] vmcore: add API to collect hardware dump in second kernel

Hi Rahul, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Rahul-Lakkireddy/vmcore-add-API-to-collect-hardware-dump-in-second-kernel/20180502-023638 config: i386-tinyconfig (attached as .config)

[PATCH net-next v7 1/3] vmcore: add API to collect hardware dump in second kernel

The sequence of actions done by device drivers to append their device specific hardware/firmware logs to /proc/vmcore are as follows: 1. During probe (before hardware is initialized), device drivers register to the vmcore module (via vmcore_add_device_dump()), with callback function, along with