Re: [PATCH net 1/1] net/smc: coordinate wait queues for nonblocking connect

2018-06-21 Thread kbuild test robot
Hi Ursula, I love your patch! Perhaps something to improve: [auto build test WARNING on net/master] url: https://github.com/0day-ci/linux/commits/Ursula-Braun/net-smc-coordinate-wait-queues-for-nonblocking-connect/20180620-180901 reproduce: # apt-get install sparse make ARCH=

Re: [PATCH net 1/1] net/smc: coordinate wait queues for nonblocking connect

2018-06-20 Thread Cong Wang
On Wed, Jun 20, 2018 at 1:07 AM, Ursula Braun wrote: > diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c > index da7f02edcd37..21c84b924ffb 100644 > --- a/net/smc/af_smc.c > +++ b/net/smc/af_smc.c > @@ -605,6 +605,8 @@ static int smc_connect(struct socket *sock, struct > sockaddr *addr, > >

[PATCH net 1/1] net/smc: coordinate wait queues for nonblocking connect

2018-06-20 Thread Ursula Braun
The recent poll change may lead to stalls for non-blocking connecting SMC sockets, since sock_poll_wait is no longer performed on the internal CLC socket, but on the outer SMC socket. kernel_connect() on the internal CLC socket returns with -EINPROGRESS, but the wake up logic does not work in all