RE: [PATCH net 1/1] net/tls: Only attach to sockets in ESTABLISHED state

2018-01-16 Thread Ilya Lesokhin
I'm sorry, I've noticed that I have a typo in my comment. It should read: /*The TLS ulp is currently supported only for TCP sockets * in ESTABLISHED state. * Supporting sockets in LISTEN state will require us * to modify the accept implementation to clone rather then * share the ulp context.

[PATCH net 1/1] net/tls: Only attach to sockets in ESTABLISHED state

2018-01-16 Thread Ilya Lesokhin
Calling accept on a TCP socket with a TLS ulp attached results in two sockets that share the same ulp context. The ulp context is freed while a socket is destroyed, so after one of the sockets is released, the second second will trigger a use after free when it tries to access the ulp context