RE: [EXTERNAL] Re: [PATCH net 1/1] net: fec: Fix temporary RMII clock reset on link up

2021-01-24 Thread Badel, Laurent
 > drivers/net/ethernet/freescale/fec_main.c: In function ‘fec_restart’: > drivers/net/ethernet/freescale/fec_main.c:958:46: warning: suggest > parentheses around ‘&&’ within ‘||’ [-Wparentheses] > 958 | (fep->quirks & FEC_QUIRK_NO_HARD_RESET) && fep->link) { > |

Re: [PATCH net 1/1] net: fec: Fix temporary RMII clock reset on link up

2021-01-22 Thread Jakub Kicinski
On Fri, 22 Jan 2021 16:13:47 +0100 Laurent Badel wrote: > fec_restart() does a hard reset of the MAC module when the link status > changes to up. This temporarily resets the R_CNTRL register which controls > the MII mode of the ENET_OUT clock. In the case of RMII, the clock > frequency momentarily

[PATCH net 1/1] net: fec: Fix temporary RMII clock reset on link up

2021-01-22 Thread Laurent Badel
fec_restart() does a hard reset of the MAC module when the link status changes to up. This temporarily resets the R_CNTRL register which controls the MII mode of the ENET_OUT clock. In the case of RMII, the clock frequency momentarily drops from 50MHz to 25MHz until the register is reconfigured. S