Re: [PATCH net 1/2] ipv6: add missing netconf notif when 'all' is updated

Le 30/08/2016 à 04:51, YOSHIFUJI Hideaki a écrit : > > > Nicolas Dichtel wrote: [snip] >> +int old_dftl = net->ipv6.devconf_dflt->forwarding; > > dflt, not dftl? Good catch!

Re: [PATCH net 1/2] ipv6: add missing netconf notif when 'all' is updated

Nicolas Dichtel wrote: > The 'default' value was not advertised. > > Fixes: f3a1bfb11ccb ("rtnl/ipv6: use netconf msg to advertise forwarding > status") > Signed-off-by: Nicolas Dichtel > --- > net/ipv6/addrconf.c | 7 +++ > 1 file changed, 7 insertions(+) > >

Re: [PATCH net 1/2] ipv6: add missing netconf notif when 'all' is updated

On 08/29/2016 05:13 PM, 吉藤英明 wrote: The 'default' value was not advertised. Fixes: f3a1bfb11ccb ("rtnl/ipv6: use netconf msg to advertise forwarding status") Signed-off-by: Nicolas Dichtel --- net/ipv6/addrconf.c | 7 +++ 1 file changed, 7 insertions(+) diff

Re: [PATCH net 1/2] ipv6: add missing netconf notif when 'all' is updated

Hi, 2016-08-29 22:00 GMT+09:00 Sergei Shtylyov : > Hello. > > On 8/29/2016 1:05 PM, Nicolas Dichtel wrote: > >> The 'default' value was not advertised. >> >> Fixes: f3a1bfb11ccb ("rtnl/ipv6: use netconf msg to advertise forwarding >> status") >> Signed-off-by:

Re: [PATCH net 1/2] ipv6: add missing netconf notif when 'all' is updated

Le 29/08/2016 à 15:00, Sergei Shtylyov a écrit : [snip] >> if (p == >ipv6.devconf_all->forwarding) { >> +int old_dftl = net->ipv6.devconf_dflt->forwarding; >> + >> net->ipv6.devconf_dflt->forwarding = newf; >> +if ((!newf) ^ (!old_dftl)) > >IIUC, !'s are not

Re: [PATCH net 1/2] ipv6: add missing netconf notif when 'all' is updated

Hello. On 8/29/2016 1:05 PM, Nicolas Dichtel wrote: The 'default' value was not advertised. Fixes: f3a1bfb11ccb ("rtnl/ipv6: use netconf msg to advertise forwarding status") Signed-off-by: Nicolas Dichtel --- net/ipv6/addrconf.c | 7 +++ 1 file changed, 7

[PATCH net 1/2] ipv6: add missing netconf notif when 'all' is updated

The 'default' value was not advertised. Fixes: f3a1bfb11ccb ("rtnl/ipv6: use netconf msg to advertise forwarding status") Signed-off-by: Nicolas Dichtel --- net/ipv6/addrconf.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/net/ipv6/addrconf.c