Re: [PATCH net 1/2] tg3: Fix for diasllow rx coalescing time to be 0

2016-08-04 Thread Siva Reddy Kallam
On Thu, Aug 4, 2016 at 3:45 AM, Michael Chan wrote: > On Wed, Aug 3, 2016 at 9:04 AM, Rick Jones wrote: >> >> Should anything then happen with: >> >> /* No rx interrupts will be generated if both are zero */ >> if ((ec->rx_coalesce_usecs == 0) && >> (ec->rx_max_coalesc

Re: [PATCH net 1/2] tg3: Fix for diasllow rx coalescing time to be 0

2016-08-03 Thread Michael Chan
On Wed, Aug 3, 2016 at 9:04 AM, Rick Jones wrote: > > Should anything then happen with: > > /* No rx interrupts will be generated if both are zero */ > if ((ec->rx_coalesce_usecs == 0) && > (ec->rx_max_coalesced_frames == 0)) > return -EINVAL; > > > whic

Re: [PATCH net 1/2] tg3: Fix for diasllow rx coalescing time to be 0

2016-08-03 Thread Rick Jones
On 08/02/2016 09:13 PM, skallam wrote: From: Satish Baddipadige When the rx coalescing time is 0, interrupts are not generated from the controller and rx path hangs. To avoid this rx hang, updating the driver to not allow rx coalescing time to be 0. Signed-off-by: Satish Baddipadige Signed-of

[PATCH net 1/2] tg3: Fix for diasllow rx coalescing time to be 0

2016-08-02 Thread skallam
From: Satish Baddipadige When the rx coalescing time is 0, interrupts are not generated from the controller and rx path hangs. To avoid this rx hang, updating the driver to not allow rx coalescing time to be 0. Signed-off-by: Satish Baddipadige Signed-off-by: Siva Reddy Kallam Signed-off-by: M