Re: [PATCH net 1/3] r8169:fix kernel log spam when set or get hardware wol setting.

Hau : [...] > > Either the driver resumes the device so that it can perform requested > > operation or it signals .set_wol failure when the device is suspended. > > > > If the driver does something else, "spam removal" translates to "silent > > failure". > > Because

RE: [PATCH net 1/3] r8169:fix kernel log spam when set or get hardware wol setting.

[...] > Nit: you may directly use "struct device *d = >pci_dev->dev;" > I will do that on my next version patch. Thanks. --Please consider the environment before printing this e-mail.

RE: [PATCH net 1/3] r8169:fix kernel log spam when set or get hardware wol setting.

[...] > > @@ -1852,12 +1863,17 @@ static int rtl8169_set_wol(struct net_device > *dev, struct ethtool_wolinfo *wol) > > tp->features |= RTL_FEATURE_WOL; > > else > > tp->features &= ~RTL_FEATURE_WOL; > > - __rtl8169_set_wol(tp, wol->wolopts); > > + if

Re: [PATCH net 1/3] r8169:fix kernel log spam when set or get hardware wol setting.

Chunhao Lin : [...] > diff --git a/drivers/net/ethernet/realtek/r8169.c > b/drivers/net/ethernet/realtek/r8169.c > index 0e62d74..f07604f 100644 > --- a/drivers/net/ethernet/realtek/r8169.c > +++ b/drivers/net/ethernet/realtek/r8169.c > @@ -1749,13 +1749,21 @@ static u32

Re: [PATCH net 1/3] r8169:fix kernel log spam when set or get hardware wol setting.

Chunhao Lin : [...] > diff --git a/drivers/net/ethernet/realtek/r8169.c > b/drivers/net/ethernet/realtek/r8169.c > index 0e62d74..f07604f 100644 > --- a/drivers/net/ethernet/realtek/r8169.c > +++ b/drivers/net/ethernet/realtek/r8169.c [...] > @@ -1852,12 +1863,17 @@ static int

[PATCH net 1/3] r8169:fix kernel log spam when set or get hardware wol setting.

NIC will be put into D3 state during runtime suspend state. When set or get hardware wol setting, driver will write or read hardware register. If we set or get hardware wol setting in runtime suspend state, because NIC will in D3 state, the register value read by driver will return all 0xff. That