Re: [PATCH net 3/3] gre: receive also TEB packets for lwtunnels

2016-04-28 Thread Jiri Benc
On Thu, 28 Apr 2016 16:49:19 +1000, Simon Horman wrote: > I have had some success wiring up Open vSwitch to use this patch for > transmit. However, I am wondering if something more is needed to allow > differentiation between packets with and without an L2 header present > on receive. The problem,

Re: [PATCH net 3/3] gre: receive also TEB packets for lwtunnels

2016-04-27 Thread Simon Horman
On Fri, Apr 22, 2016 at 07:44:08PM +0200, Jiri Benc wrote: > For ipgre interfaces in collect metadata mode, receive also traffic with > encapsulated Ethernet headers. The lwtunnel users are supposed to sort this > out correctly. This allows to have mixed Ethernet + L3-only traffic on the > same lwt

Re: [PATCH net 3/3] gre: receive also TEB packets for lwtunnels

2016-04-24 Thread Jiri Benc
On Fri, 22 Apr 2016 20:40:13 -0700, pravin shelar wrote: > But skb->protocol is not set to ETH_P_TEB anywhere in ip-gre module. > Am I missing something? Ah, I see your point. It needs to be solved a bit differently, though, we need to call __iptunnel_pull_header instead of iptunnel_pull_header fo

Re: [PATCH net 3/3] gre: receive also TEB packets for lwtunnels

2016-04-24 Thread Jiri Benc
On Sat, 23 Apr 2016 15:09:16 +1000, Simon Horman wrote: > On Sat, Apr 23, 2016 at 03:49:38AM +0200, Thomas Graf wrote: > > I may be missing some context. Is anyone using this already or is this > > preparing the stage for another user? It's not clear to me from the > > commit message. > > Hi Thoma

Re: [PATCH net 3/3] gre: receive also TEB packets for lwtunnels

2016-04-22 Thread Simon Horman
On Sat, Apr 23, 2016 at 03:49:38AM +0200, Thomas Graf wrote: > On 04/22/16 at 07:44pm, Jiri Benc wrote: > > For ipgre interfaces in collect metadata mode, receive also traffic with > > encapsulated Ethernet headers. The lwtunnel users are supposed to sort this > > out correctly. This allows to have

Re: [PATCH net 3/3] gre: receive also TEB packets for lwtunnels

2016-04-22 Thread pravin shelar
On Fri, Apr 22, 2016 at 2:27 PM, Jiri Benc wrote: > On Fri, 22 Apr 2016 14:07:01 -0700, pravin shelar wrote: >> On Fri, Apr 22, 2016 at 10:44 AM, Jiri Benc wrote: >> > For ipgre interfaces in collect metadata mode, receive also traffic with >> > encapsulated Ethernet headers. The lwtunnel users a

Re: [PATCH net 3/3] gre: receive also TEB packets for lwtunnels

2016-04-22 Thread Thomas Graf
On 04/22/16 at 07:44pm, Jiri Benc wrote: > For ipgre interfaces in collect metadata mode, receive also traffic with > encapsulated Ethernet headers. The lwtunnel users are supposed to sort this > out correctly. This allows to have mixed Ethernet + L3-only traffic on the > same lwtunnel interface. >

Re: [PATCH net 3/3] gre: receive also TEB packets for lwtunnels

2016-04-22 Thread Jiri Benc
On Fri, 22 Apr 2016 14:07:01 -0700, pravin shelar wrote: > On Fri, Apr 22, 2016 at 10:44 AM, Jiri Benc wrote: > > For ipgre interfaces in collect metadata mode, receive also traffic with > > encapsulated Ethernet headers. The lwtunnel users are supposed to sort this > > out correctly. This allows

Re: [PATCH net 3/3] gre: receive also TEB packets for lwtunnels

2016-04-22 Thread pravin shelar
On Fri, Apr 22, 2016 at 10:44 AM, Jiri Benc wrote: > For ipgre interfaces in collect metadata mode, receive also traffic with > encapsulated Ethernet headers. The lwtunnel users are supposed to sort this > out correctly. This allows to have mixed Ethernet + L3-only traffic on the > same lwtunnel i

[PATCH net 3/3] gre: receive also TEB packets for lwtunnels

2016-04-22 Thread Jiri Benc
For ipgre interfaces in collect metadata mode, receive also traffic with encapsulated Ethernet headers. The lwtunnel users are supposed to sort this out correctly. This allows to have mixed Ethernet + L3-only traffic on the same lwtunnel interface. To keep backwards compatibility and prevent any s