Re: [PATCH net 9/9] sch_tbf: fix two null pointer dereferences on init failure

2017-08-30 Thread Nikolay Aleksandrov
On 30/08/17 20:37, Cong Wang wrote: > On Wed, Aug 30, 2017 at 2:49 AM, Nikolay Aleksandrov > wrote: >> Reproduce: >> $ sysctl net.core.default_qdisc=tbf >> $ ip l set ethX up > > I once upon a time had a patch to disallow those qdisc's > to be default. Probably I

Re: [PATCH net 9/9] sch_tbf: fix two null pointer dereferences on init failure

2017-08-30 Thread Cong Wang
On Wed, Aug 30, 2017 at 2:49 AM, Nikolay Aleksandrov wrote: > Reproduce: > $ sysctl net.core.default_qdisc=tbf > $ ip l set ethX up I once upon a time had a patch to disallow those qdisc's to be default. Probably I should resend it.

[PATCH net 9/9] sch_tbf: fix two null pointer dereferences on init failure

2017-08-30 Thread Nikolay Aleksandrov
sch_tbf calls qdisc_watchdog_cancel() in both its ->reset and ->destroy callbacks but it may fail before the timer is initialized due to missing options (either not supplied by user-space or set as a default qdisc), also q->qdisc is used by ->reset and ->destroy so we need it initialized.