Re: [PATCH net RESEND] PCI: fix oops when try to find Root Port for a PCI device

2017-08-16 Thread Michael Ellerman
Thierry Reding writes: ... > > In case of Tegra, dev actually points to the root port. Now if I read > the above code correctly, highest_pcie_bridge will still be NULL in that > case, which in turn will return NULL from pci_find_pcie_root_port(). But > shouldn't it

Re: [PATCH net RESEND] PCI: fix oops when try to find Root Port for a PCI device

2017-08-16 Thread Ding Tianhong
On 2017/8/17 4:59, David Miller wrote: > From: Bjorn Helgaas > Date: Wed, 16 Aug 2017 15:02:37 -0500 > >> Your fix looks right to me. > > Someone please submit this fix formally because this change is now in > Linus's tree. > I will send it. > Thank you. > > . >

Re: [PATCH net RESEND] PCI: fix oops when try to find Root Port for a PCI device

2017-08-16 Thread David Miller
From: Bjorn Helgaas Date: Wed, 16 Aug 2017 15:02:37 -0500 > Your fix looks right to me. Someone please submit this fix formally because this change is now in Linus's tree. Thank you.

Re: [PATCH net RESEND] PCI: fix oops when try to find Root Port for a PCI device

2017-08-16 Thread Bjorn Helgaas
On Wed, Aug 16, 2017 at 09:33:03PM +0200, Thierry Reding wrote: > On Tue, Aug 15, 2017 at 12:03:31PM -0500, Bjorn Helgaas wrote: > > On Tue, Aug 15, 2017 at 11:24:48PM +0800, Ding Tianhong wrote: > > > Eric report a oops when booting the system after applying > > > the commit a99b646afa8a ("PCI:

Re: [PATCH net RESEND] PCI: fix oops when try to find Root Port for a PCI device

2017-08-16 Thread Thierry Reding
On Tue, Aug 15, 2017 at 12:03:31PM -0500, Bjorn Helgaas wrote: > On Tue, Aug 15, 2017 at 11:24:48PM +0800, Ding Tianhong wrote: > > Eric report a oops when booting the system after applying > > the commit a99b646afa8a ("PCI: Disable PCIe Relaxed..."): > > ... > > > It looks like the

Re: [PATCH net RESEND] PCI: fix oops when try to find Root Port for a PCI device

2017-08-15 Thread David Miller
From: Bjorn Helgaas Date: Tue, 15 Aug 2017 12:03:31 -0500 > On Tue, Aug 15, 2017 at 11:24:48PM +0800, Ding Tianhong wrote: >> Eric report a oops when booting the system after applying >> the commit a99b646afa8a ("PCI: Disable PCIe Relaxed..."): >> ... > >> It looks like the

Re: [PATCH net RESEND] PCI: fix oops when try to find Root Port for a PCI device

2017-08-15 Thread Bjorn Helgaas
On Tue, Aug 15, 2017 at 11:24:48PM +0800, Ding Tianhong wrote: > Eric report a oops when booting the system after applying > the commit a99b646afa8a ("PCI: Disable PCIe Relaxed..."): > ... > It looks like the pci_find_pcie_root_port() was trying to > find the Root Port for the PCI device which is

[PATCH net RESEND] PCI: fix oops when try to find Root Port for a PCI device

2017-08-15 Thread Ding Tianhong
Eric report a oops when booting the system after applying the commit a99b646afa8a ("PCI: Disable PCIe Relaxed..."): [4.241029] BUG: unable to handle kernel NULL pointer dereference at 0050 [4.247001] IP: pci_find_pcie_root_port+0x62/0x80 [4.253011] PGD 0 [4.253011]