Re: [PATCH net v2] bnxt_en: Fix TX timeout during netpoll.

2018-09-26 Thread Eric Dumazet
On Wed, Sep 26, 2018 at 8:49 PM Song Liu wrote: > > We also need this patch from Eric: > > https://marc.info/?l=linux-netdev=153780304905946 > I will submit this formally tomorrow, thanks.

Re: [PATCH net v2] bnxt_en: Fix TX timeout during netpoll.

2018-09-26 Thread Song Liu
> On Sep 26, 2018, at 8:33 PM, David Miller wrote: > > From: Michael Chan > Date: Wed, 26 Sep 2018 00:41:04 -0400 > >> The current netpoll implementation in the bnxt_en driver has problems >> that may miss TX completion events. bnxt_poll_work() in effect is >> only handling at most 1 TX

Re: [PATCH net v2] bnxt_en: Fix TX timeout during netpoll.

2018-09-26 Thread David Miller
From: Michael Chan Date: Wed, 26 Sep 2018 00:41:04 -0400 > The current netpoll implementation in the bnxt_en driver has problems > that may miss TX completion events. bnxt_poll_work() in effect is > only handling at most 1 TX packet before exiting. In addition, > there may be in flight TX

Re: [PATCH net v2] bnxt_en: Fix TX timeout during netpoll.

2018-09-26 Thread Song Liu
> On Sep 25, 2018, at 9:41 PM, Michael Chan wrote: > > The current netpoll implementation in the bnxt_en driver has problems > that may miss TX completion events. bnxt_poll_work() in effect is > only handling at most 1 TX packet before exiting. In addition, > there may be in flight TX

[PATCH net v2] bnxt_en: Fix TX timeout during netpoll.

2018-09-25 Thread Michael Chan
The current netpoll implementation in the bnxt_en driver has problems that may miss TX completion events. bnxt_poll_work() in effect is only handling at most 1 TX packet before exiting. In addition, there may be in flight TX completions that ->poll() may miss even after we fix bnxt_poll_work()