Re: [PATCH net v2] net: nsid cannot be allocated for a dead netns

2016-11-17 Thread Cong Wang
On Thu, Nov 17, 2016 at 12:41 AM, Nicolas Dichtel wrote: > Le 17/11/2016 à 07:32, Cong Wang a écrit : > [snip] >> since Nicolas' patch doesn't even compile... > It's always surprising how agressive you are, really :( > Can you show me the compilation error of this patch (we are talking about the

Re: [PATCH net v2] net: nsid cannot be allocated for a dead netns

2016-11-17 Thread Nicolas Dichtel
Le 17/11/2016 à 07:32, Cong Wang a écrit : [snip] > since Nicolas' patch doesn't even compile... It's always surprising how agressive you are, really :( Can you show me the compilation error of this patch (we are talking about the v2 patch here)?

Re: [PATCH net v2] net: nsid cannot be allocated for a dead netns

2016-11-17 Thread Nicolas Dichtel
Le 17/11/2016 à 05:17, David Miller a écrit : [snip] > Indeed, this looks cleaner, Nicolas? Yes, I agree. Cong already sent a v3 of my patch, let's apply it.

Re: [PATCH net v2] net: nsid cannot be allocated for a dead netns

2016-11-16 Thread Cong Wang
On Wed, Nov 16, 2016 at 8:17 PM, David Miller wrote: > From: Cong Wang > Date: Wed, 16 Nov 2016 09:29:29 -0800 > >> On Wed, Nov 16, 2016 at 1:49 AM, Nicolas Dichtel >> wrote: >>> diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c >>> index f61c0e02a413..63f65387f4e1 100644 >>> ---

Re: [PATCH net v2] net: nsid cannot be allocated for a dead netns

2016-11-16 Thread David Miller
From: Cong Wang Date: Wed, 16 Nov 2016 09:29:29 -0800 > On Wed, Nov 16, 2016 at 1:49 AM, Nicolas Dichtel > wrote: >> diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c >> index f61c0e02a413..63f65387f4e1 100644 >> --- a/net/core/net_namespace.c >> +++ b/net/core/net_namespace.c >>

Re: [PATCH net v2] net: nsid cannot be allocated for a dead netns

2016-11-16 Thread Cong Wang
On Wed, Nov 16, 2016 at 1:49 AM, Nicolas Dichtel wrote: > diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c > index f61c0e02a413..63f65387f4e1 100644 > --- a/net/core/net_namespace.c > +++ b/net/core/net_namespace.c > @@ -159,6 +159,9 @@ static int alloc_netid(struct net *net, struc

[PATCH net v2] net: nsid cannot be allocated for a dead netns

2016-11-16 Thread Nicolas Dichtel
Andrei reports the following kmemleak error: unreferenced object 0x91badb543950 (size 2096): comm "kworker/u4:0", pid 6, jiffies 4295152553 (age 28.418s) hex dump (first 32 bytes): 00 00 00 00 00 00 00 00 00 cb 5f df ba 91 ff ff .._. 00 00 00 00 00 00 00 00 00 00 00 00