Re: [PATCH net v2] net: phy: Correctly process PHY_HALTED in phy_stop_machine()

2017-08-30 Thread Florian Fainelli
On 08/30/2017 05:13 PM, David Daney wrote: > On 07/31/2017 05:28 PM, David Miller wrote: >> From: Florian Fainelli >> Date: Fri, 28 Jul 2017 11:58:36 -0700 >> >>> Marc reported that he was not getting the PHY library adjust_link() >>> callback function to run when calling

Re: [PATCH net v2] net: phy: Correctly process PHY_HALTED in phy_stop_machine()

2017-08-30 Thread Florian Fainelli
On 08/30/2017 05:13 PM, David Daney wrote: > On 07/31/2017 05:28 PM, David Miller wrote: >> From: Florian Fainelli >> Date: Fri, 28 Jul 2017 11:58:36 -0700 >> >>> Marc reported that he was not getting the PHY library adjust_link() >>> callback function to run when calling

Re: [PATCH net v2] net: phy: Correctly process PHY_HALTED in phy_stop_machine()

2017-08-30 Thread David Daney
And of course I mess up my pretty picture, see below. On 08/30/2017 05:13 PM, David Daney wrote: On 07/31/2017 05:28 PM, David Miller wrote: From: Florian Fainelli Date: Fri, 28 Jul 2017 11:58:36 -0700 Marc reported that he was not getting the PHY library adjust_link()

Re: [PATCH net v2] net: phy: Correctly process PHY_HALTED in phy_stop_machine()

2017-08-30 Thread David Daney
On 07/31/2017 05:28 PM, David Miller wrote: From: Florian Fainelli Date: Fri, 28 Jul 2017 11:58:36 -0700 Marc reported that he was not getting the PHY library adjust_link() callback function to run when calling phy_stop() + phy_disconnect() which does not indeed happen

Re: [PATCH net v2] net: phy: Correctly process PHY_HALTED in phy_stop_machine()

2017-07-31 Thread David Miller
From: Florian Fainelli Date: Fri, 28 Jul 2017 11:58:36 -0700 > Marc reported that he was not getting the PHY library adjust_link() > callback function to run when calling phy_stop() + phy_disconnect() > which does not indeed happen because we set the state machine to >

Re: [PATCH net v2] net: phy: Correctly process PHY_HALTED in phy_stop_machine()

2017-07-28 Thread Marc Gonzalez
On 28/07/2017 20:58, Florian Fainelli wrote: > Marc reported that he was not getting the PHY library adjust_link() > callback function to run when calling phy_stop() + phy_disconnect() > which does not indeed happen because we set the state machine to > PHY_HALTED but we don't get to run it to

[PATCH net v2] net: phy: Correctly process PHY_HALTED in phy_stop_machine()

2017-07-28 Thread Florian Fainelli
Marc reported that he was not getting the PHY library adjust_link() callback function to run when calling phy_stop() + phy_disconnect() which does not indeed happen because we set the state machine to PHY_HALTED but we don't get to run it to process this state past that point. Fix this with a