Re: [PATCH net v2] sctp: fix dst refcnt leak in sctp_v4_get_dst

2018-02-05 Thread Marcelo Ricardo Leitner
On Mon, Feb 05, 2018 at 03:33:11PM +0200, Tommi Rantala wrote: > Fix dst reference count leak in sctp_v4_get_dst() introduced in commit > 410f03831 ("sctp: add routing output fallback"): > Patch LGTM. Will wait the respin for Acking. Thanks.

Re: [PATCH net v2] sctp: fix dst refcnt leak in sctp_v4_get_dst

2018-02-05 Thread David Miller
From: Tommi Rantala Date: Mon, 5 Feb 2018 15:33:11 +0200 > Fixes: 410f03831 ("sctp: add routing output fallback") > Signed-off-by: Tommi Rantala I would add another Fixes tag mentioning commit: 0ca50d12fe46cdf3c0dc9ec5ca98607a52afdc62 ("sctp: fix src address selection if using

[PATCH net v2] sctp: fix dst refcnt leak in sctp_v4_get_dst

2018-02-05 Thread Tommi Rantala
Fix dst reference count leak in sctp_v4_get_dst() introduced in commit 410f03831 ("sctp: add routing output fallback"): When walking the address_list, successive ip_route_output_key() calls may return the same rt->dst with the reference incremented on each call. The code would not decrement the d