[PATCH net v2] tcp: Force updating pcount after skb_pull() during mtu probing

2015-06-05 Thread Martin KaFai Lau
The problem is caught by this WARN_ON(len > skb->len) in tcp_fragment(): [] warn_slowpath_null+0x1a/0x20 [] tcp_fragment+0x2a0/0x2b0 [] tcp_mark_head_lost+0x196/0x230 [] tcp_update_scoreboard+0x4d/0x80 [] tcp_fastretrans_alert+0x6ac/0xa90 [] tcp_ack+0x9d4/0x10e0 [] tcp_rcv_established+0x309/0x7e0

Re: [PATCH net v2] tcp: Force updating pcount after skb_pull() during mtu probing

2015-06-05 Thread Eric Dumazet
On Fri, 2015-06-05 at 17:46 -0700, Martin KaFai Lau wrote: > The problem is caught by this WARN_ON(len > skb->len) in tcp_fragment(): > > [] warn_slowpath_null+0x1a/0x20 > [] tcp_fragment+0x2a0/0x2b0 > [] tcp_mark_head_lost+0x196/0x230 > [] tcp_update_scoreboard+0x4d/0x80 > [] tcp_fastretrans_aler

Re: [PATCH net v2] tcp: Force updating pcount after skb_pull() during mtu probing

2015-06-08 Thread Martin KaFai Lau
On Fri, Jun 05, 2015 at 06:11:33PM -0700, Eric Dumazet wrote: > On Fri, 2015-06-05 at 17:46 -0700, Martin KaFai Lau wrote: > > The problem is caught by this WARN_ON(len > skb->len) in tcp_fragment(): > > > > [] warn_slowpath_null+0x1a/0x20 > > [] tcp_fragment+0x2a0/0x2b0 > > [] tcp_mark_head_lost+

Re: [PATCH net v2] tcp: Force updating pcount after skb_pull() during mtu probing

2015-06-08 Thread Eric Dumazet
On Mon, 2015-06-08 at 10:58 -0700, Martin KaFai Lau wrote: > It seems the invariant does not hold at this point also. > Should the invariant fix be something for net-next? or Would you like > to post a patch for it? This patch definitely can target net-next, it is not a new regression. Once full

Re: [PATCH net v2] tcp: Force updating pcount after skb_pull() during mtu probing

2015-06-09 Thread Eric Dumazet
On Mon, 2015-06-08 at 11:11 -0700, Eric Dumazet wrote: > On Mon, 2015-06-08 at 10:58 -0700, Martin KaFai Lau wrote: > > > It seems the invariant does not hold at this point also. > > Should the invariant fix be something for net-next? or Would you like > > to post a patch for it? > > This patch d

Re: [PATCH net v2] tcp: Force updating pcount after skb_pull() during mtu probing

2015-06-09 Thread Martin KaFai Lau
On Tue, Jun 09, 2015 at 10:06:25AM -0700, Eric Dumazet wrote: > I've been working on this, but still can get the bug triggering in > tcp_fragment(), no matter what (Neal patch , yours, mine...) Can you describe the test case that can reproduce it? -- To unsubscribe from this list: send the line "un

Re: [PATCH net v2] tcp: Force updating pcount after skb_pull() during mtu probing

2015-06-09 Thread Eric Dumazet
On Tue, 2015-06-09 at 10:45 -0700, Martin KaFai Lau wrote: > On Tue, Jun 09, 2015 at 10:06:25AM -0700, Eric Dumazet wrote: > > I've been working on this, but still can get the bug triggering in > > tcp_fragment(), no matter what (Neal patch , yours, mine...) > Can you describe the test case that ca