Re: [PATCH net v2] team: don't call netdev_change_features under team->lock

2016-05-25 Thread David Miller
From: Ivan Vecera Date: Wed, 25 May 2016 21:21:52 +0200 > The team_device_event() notifier calls team_compute_features() to fix > vlan_features under team->lock to protect team->port_list. The problem is > that subsequent __team_compute_features() calls netdev_change_features() > to propagate vla

Re: [PATCH net v2] team: don't call netdev_change_features under team->lock

2016-05-25 Thread Jiri Pirko
Wed, May 25, 2016 at 09:21:52PM CEST, ivec...@redhat.com wrote: >The team_device_event() notifier calls team_compute_features() to fix >vlan_features under team->lock to protect team->port_list. The problem is >that subsequent __team_compute_features() calls netdev_change_features() >to propagate v

[PATCH net v2] team: don't call netdev_change_features under team->lock

2016-05-25 Thread Ivan Vecera
The team_device_event() notifier calls team_compute_features() to fix vlan_features under team->lock to protect team->port_list. The problem is that subsequent __team_compute_features() calls netdev_change_features() to propagate vlan_features to upper vlan devices while team->lock is still taken.