Re: [PATCH net v2 2/3] tunnels: Don't apply GRO to multiple layers of encapsulation.

On Mon, Mar 28, 2016 at 5:50 PM, Tom Herbert wrote: > On Mon, Mar 28, 2016 at 4:34 PM, Jesse Gross wrote: >> * A packet is received that is encapsulated with two layers of GRE. It >> looks like this: Eth|IP|GRE|IP|GRE|IP|TCP >> * The packet is processed

Re: [PATCH net v2 2/3] tunnels: Don't apply GRO to multiple layers of encapsulation.

On Mon, Mar 28, 2016 at 4:34 PM, Jesse Gross wrote: > On Mon, Mar 28, 2016 at 3:10 PM, Tom Herbert wrote: >> On Mon, Mar 28, 2016 at 1:34 PM, Alexander Duyck >> wrote: >>> On Mon, Mar 28, 2016 at 1:03 PM, Tom Herbert

Re: [PATCH net v2 2/3] tunnels: Don't apply GRO to multiple layers of encapsulation.

On Mon, Mar 28, 2016 at 3:10 PM, Tom Herbert wrote: > On Mon, Mar 28, 2016 at 1:34 PM, Alexander Duyck > wrote: >> On Mon, Mar 28, 2016 at 1:03 PM, Tom Herbert wrote: >>> On Mon, Mar 28, 2016 at 12:31 PM, Alexander Duyck >>>

Re: [PATCH net v2 2/3] tunnels: Don't apply GRO to multiple layers of encapsulation.

On Mon, Mar 28, 2016 at 1:34 PM, Alexander Duyck wrote: > On Mon, Mar 28, 2016 at 1:03 PM, Tom Herbert wrote: >> On Mon, Mar 28, 2016 at 12:31 PM, Alexander Duyck >> wrote: >>> On Mon, Mar 28, 2016 at 11:47 AM, Tom

Re: [PATCH net v2 2/3] tunnels: Don't apply GRO to multiple layers of encapsulation.

On Mon, Mar 28, 2016 at 1:03 PM, Tom Herbert wrote: > On Mon, Mar 28, 2016 at 12:31 PM, Alexander Duyck > wrote: >> On Mon, Mar 28, 2016 at 11:47 AM, Tom Herbert wrote: >>> On Mon, Mar 28, 2016 at 10:37 AM, Alexander Duyck

Re: [PATCH net v2 2/3] tunnels: Don't apply GRO to multiple layers of encapsulation.

On Mon, Mar 28, 2016 at 12:31 PM, Alexander Duyck wrote: > On Mon, Mar 28, 2016 at 11:47 AM, Tom Herbert wrote: >> On Mon, Mar 28, 2016 at 10:37 AM, Alexander Duyck >> wrote: >>> On Mon, Mar 28, 2016 at 9:31 AM, Tom

Re: [PATCH net v2 2/3] tunnels: Don't apply GRO to multiple layers of encapsulation.

From: Jesse Gross Date: Sun, 27 Mar 2016 21:38:34 -0700 > Generally speaking, multiple levels of encapsulation offload are not > valid. That's very much not true Jesse. Please fix the regression you introduced or I will have no choice but to revert your entire set of changes.

Re: [PATCH net v2 2/3] tunnels: Don't apply GRO to multiple layers of encapsulation.

On Mon, Mar 28, 2016 at 11:47 AM, Tom Herbert wrote: > On Mon, Mar 28, 2016 at 10:37 AM, Alexander Duyck > wrote: >> On Mon, Mar 28, 2016 at 9:31 AM, Tom Herbert wrote: >>> On Sun, Mar 27, 2016 at 9:38 PM, Jesse Gross

Re: [PATCH net v2 2/3] tunnels: Don't apply GRO to multiple layers of encapsulation.

On Mon, Mar 28, 2016 at 10:37 AM, Alexander Duyck wrote: > On Mon, Mar 28, 2016 at 9:31 AM, Tom Herbert wrote: >> On Sun, Mar 27, 2016 at 9:38 PM, Jesse Gross wrote: >>> On Sat, Mar 26, 2016 at 12:41 PM, Tom Herbert

Re: [PATCH net v2 2/3] tunnels: Don't apply GRO to multiple layers of encapsulation.

On Mon, Mar 28, 2016 at 9:31 AM, Tom Herbert wrote: > On Sun, Mar 27, 2016 at 9:38 PM, Jesse Gross wrote: >> On Sat, Mar 26, 2016 at 12:41 PM, Tom Herbert wrote: >>> On Sat, Mar 19, 2016 at 9:32 AM, Jesse Gross

Re: [PATCH net v2 2/3] tunnels: Don't apply GRO to multiple layers of encapsulation.

On Sun, Mar 27, 2016 at 9:38 PM, Jesse Gross wrote: > On Sat, Mar 26, 2016 at 12:41 PM, Tom Herbert wrote: >> On Sat, Mar 19, 2016 at 9:32 AM, Jesse Gross wrote: >>> When drivers express support for TSO of encapsulated packets, they >>>

Re: [PATCH net v2 2/3] tunnels: Don't apply GRO to multiple layers of encapsulation.

On Sat, Mar 26, 2016 at 12:41 PM, Tom Herbert wrote: > On Sat, Mar 19, 2016 at 9:32 AM, Jesse Gross wrote: >> When drivers express support for TSO of encapsulated packets, they >> only mean that they can do it for one layer of encapsulation. >> Supporting

Re: [PATCH net v2 2/3] tunnels: Don't apply GRO to multiple layers of encapsulation.

On Sat, Mar 19, 2016 at 9:32 AM, Jesse Gross wrote: > When drivers express support for TSO of encapsulated packets, they > only mean that they can do it for one layer of encapsulation. > Supporting additional levels would mean updating, at a minimum, > more IP length fields and

[PATCH net v2 2/3] tunnels: Don't apply GRO to multiple layers of encapsulation.

When drivers express support for TSO of encapsulated packets, they only mean that they can do it for one layer of encapsulation. Supporting additional levels would mean updating, at a minimum, more IP length fields and they are unaware of this. No encapsulation device expresses support for