Re: [PATCH net v3] sctp: fix dst refcnt leak in sctp_v4_get_dst

2018-02-06 Thread Dmitry Vyukov
On Tue, Feb 6, 2018 at 6:06 AM, Xin Long wrote: > On Tue, Feb 6, 2018 at 7:20 AM, David Ahern wrote: >> On 2/5/18 12:48 PM, Tommi Rantala wrote: >>> Fix dst reference count leak in sctp_v4_get_dst() introduced in commit >>> 410f03831 ("sctp: add routing output fallback"): >>> >>> When walking the

Re: [PATCH net v3] sctp: fix dst refcnt leak in sctp_v4_get_dst

2018-02-05 Thread Xin Long
On Tue, Feb 6, 2018 at 7:20 AM, David Ahern wrote: > On 2/5/18 12:48 PM, Tommi Rantala wrote: >> Fix dst reference count leak in sctp_v4_get_dst() introduced in commit >> 410f03831 ("sctp: add routing output fallback"): >> >> When walking the address_list, successive ip_route_output_key() calls >>

Re: [PATCH net v3] sctp: fix dst refcnt leak in sctp_v4_get_dst

2018-02-05 Thread David Miller
From: Tommi Rantala Date: Mon, 5 Feb 2018 21:48:14 +0200 > Fix dst reference count leak in sctp_v4_get_dst() introduced in commit > 410f03831 ("sctp: add routing output fallback"): > > When walking the address_list, successive ip_route_output_key() calls > may return the same rt->dst with the r

Re: [PATCH net v3] sctp: fix dst refcnt leak in sctp_v4_get_dst

2018-02-05 Thread Neil Horman
On Mon, Feb 05, 2018 at 09:48:14PM +0200, Tommi Rantala wrote: > Fix dst reference count leak in sctp_v4_get_dst() introduced in commit > 410f03831 ("sctp: add routing output fallback"): > > When walking the address_list, successive ip_route_output_key() calls > may return the same rt->dst with th

Re: [PATCH net v3] sctp: fix dst refcnt leak in sctp_v4_get_dst

2018-02-05 Thread David Ahern
On 2/5/18 12:48 PM, Tommi Rantala wrote: > Fix dst reference count leak in sctp_v4_get_dst() introduced in commit > 410f03831 ("sctp: add routing output fallback"): > > When walking the address_list, successive ip_route_output_key() calls > may return the same rt->dst with the reference incremente

Re: [PATCH net v3] sctp: fix dst refcnt leak in sctp_v4_get_dst

2018-02-05 Thread Marcelo Ricardo Leitner
On Mon, Feb 05, 2018 at 09:48:14PM +0200, Tommi Rantala wrote: > Fix dst reference count leak in sctp_v4_get_dst() introduced in commit > 410f03831 ("sctp: add routing output fallback"): > > When walking the address_list, successive ip_route_output_key() calls > may return the same rt->dst with th

[PATCH net v3] sctp: fix dst refcnt leak in sctp_v4_get_dst

2018-02-05 Thread Tommi Rantala
Fix dst reference count leak in sctp_v4_get_dst() introduced in commit 410f03831 ("sctp: add routing output fallback"): When walking the address_list, successive ip_route_output_key() calls may return the same rt->dst with the reference incremented on each call. The code would not decrement the d