Re: [PATCH net v4] sctp: asconf's process should verify address parameter is in the beginning

2015-08-27 Thread David Miller
From: Xin Long Date: Thu, 27 Aug 2015 16:26:34 +0800 > in sctp_process_asconf(), we get address parameter from the beginning of > the addip params. but we never check if it's really there. if the addr > param is not there, it still can pass sctp_verify_asconf(), then to be > handled by sctp_proce

Re: [PATCH net v4] sctp: asconf's process should verify address parameter is in the beginning

2015-08-27 Thread Vlad Yasevich
On 08/27/2015 04:26 AM, Xin Long wrote: > in sctp_process_asconf(), we get address parameter from the beginning of > the addip params. but we never check if it's really there. if the addr > param is not there, it still can pass sctp_verify_asconf(), then to be > handled by sctp_process_asconf(), it

[PATCH net v4] sctp: asconf's process should verify address parameter is in the beginning

2015-08-27 Thread Xin Long
in sctp_process_asconf(), we get address parameter from the beginning of the addip params. but we never check if it's really there. if the addr param is not there, it still can pass sctp_verify_asconf(), then to be handled by sctp_process_asconf(), it will not be safe. so add a code in sctp_verify

Re: [PATCH net v4] sctp: asconf's process should verify address parameter is in the beginning

2015-08-27 Thread lucien xin
On Thu, Aug 27, 2015 at 5:33 AM, Vlad Yasevich wrote: > On 08/26/2015 05:03 PM, Xin Long wrote: >> in sctp_process_asconf(), we get address parameter from the beginning of >> the addip params. but we never check if it's really there. if the addr >> param is not there, it still can pass sctp_verify

Re: [PATCH net v4] sctp: asconf's process should verify address parameter is in the beginning

2015-08-26 Thread Vlad Yasevich
On 08/26/2015 05:03 PM, Xin Long wrote: > in sctp_process_asconf(), we get address parameter from the beginning of > the addip params. but we never check if it's really there. if the addr > param is not there, it still can pass sctp_verify_asconf(), then to be > handled by sctp_process_asconf(), it

[PATCH net v4] sctp: asconf's process should verify address parameter is in the beginning

2015-08-26 Thread Xin Long
in sctp_process_asconf(), we get address parameter from the beginning of the addip params. but we never check if it's really there. if the addr param is not there, it still can pass sctp_verify_asconf(), then to be handled by sctp_process_asconf(), it will not be safe. so add detection in sctp_ver